fix(orchestrator): return 408 on timeout #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
approved these changes
Feb 18, 2025
TBonnin
approved these changes
Feb 24, 2025
| @@ -51,7 +51,7 @@ const handler = (scheduler: Scheduler, eventEmitter: EventEmitter) => { | |||
| cleanupAndRespond((res) => res.status(200).json({ state: completedTask.state, output: completedTask.output })); | |||
| }; | |||
| const timeout = setTimeout(() => { | |||
| cleanupAndRespond((res) => res.status(500).send({ error: { code: 'timeout', message: 'Long polling timeout' } })); | |||
| cleanupAndRespond((res) => res.status(408).send({ error: { code: 'timeout', message: 'Long polling timeout' } })); | |||
There was a problem hiding this comment.
That's fine, the status code is not used. The client logic relies on the error field in the content.
nango/packages/orchestrator/lib/clients/client.ts
Lines 177 to 185 in 2ec075a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To reduce the number of identified error in the logs