Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): added a flag that when passed to proxy configuration will not include the auth headers #3550

Closed
wants to merge 7 commits into from

Conversation

hassan254-prog
Copy link
Contributor

  • Added a flag includeAuthentication that when passed as false to proxy configuration, will not include the auth headers

@hassan254-prog hassan254-prog self-assigned this Feb 21, 2025
@hassan254-prog hassan254-prog marked this pull request as draft February 21, 2025 10:30
@bodinsamuel
Copy link
Collaborator

Can we have some context? ☺️

@hassan254-prog
Copy link
Contributor Author

Can we have some context? ☺️

This issue occurs in the context of AWS S3. When a user provides a pre-signed URL that uses X-Amz-* query parameters for authentication while building proxies, AWS returns the error: "Only one authentication mechanism is allowed." This happens because, even when overridden in ProxyConfiguration, an empty string is still passed in the Authorization header.

To fix this, users can now set the flag includeAuthentication: false, ensuring the Authorization header is completely omitted.

@hassan254-prog hassan254-prog marked this pull request as ready for review February 21, 2025 15:49
@hassan254-prog
Copy link
Contributor Author

closing in favor of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants