-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 4.0.0-第一轮 #520
refactor: 4.0.0-第一轮 #520
Conversation
审核者指南 by Sourcery此 PR 实现了包依赖重组和接口更新。更改涉及将一些依赖从运行时依赖移动到开发依赖,更新 TypeScript 接口,并相应地调整构建配置。 更新的 NodeQQNTWrapperUtil 接口类图classDiagram
class NodeQQNTWrapperUtil {
+get(): NodeQQNTWrapperUtil
+getNTUserDataInfoConfig(): string
}
文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis PR implements a package dependency reorganization and interface updates. The changes involve moving some dependencies from runtime to development dependencies, updating TypeScript interfaces, and adjusting the build configuration accordingly. Updated class diagram for NodeQQNTWrapperUtil interfaceclassDiagram
class NodeQQNTWrapperUtil {
+get(): NodeQQNTWrapperUtil
+getNTUserDataInfoConfig(): string
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗨 @MliKiowa - 我已经审查了你的更改 - 这里有一些反馈:
总体评论:
- 请提供重大版本升级到 4.0.0 的破坏性更改的描述
- 如果 fluent-ffmpeg 和 qrcode-terminal 在运行时需要,将它们移到 devDependencies 可能是不正确的。请验证此更改。
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @MliKiowa - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a description of the breaking changes that justify the major version bump to 4.0.0
- Moving fluent-ffmpeg and qrcode-terminal to devDependencies may be incorrect if they're needed at runtime. Please verify this change.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
Summary by Sourcery
重构 NapCatOneBot11Adapter 和 NapCatCore 类以改进初始化逻辑和代码结构。更新 package.json 以调整 dependencies 和 devDependencies。修改 NodeQQNTWrapperUtil 接口和 NodeIKernelGroupService 方法以更好地处理类型。
增强功能:
构建:
Original summary in English
Summary by Sourcery
Refactor the NapCatOneBot11Adapter and NapCatCore classes to improve initialization logic and code structure. Update the package.json to adjust dependencies and devDependencies. Modify the NodeQQNTWrapperUtil interface and NodeIKernelGroupService method for better type handling.
Enhancements:
Build: