-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
新增send_poke #662
新增send_poke #662
Conversation
审核者指南 by Sourcery此拉取请求实现了一个新的动作 send_poke 动作流程的时序图sequenceDiagram
participant Client
participant SendPoke
participant PacketOperationContext
Client->>SendPoke: send_poke(user_id, [group_id])
SendPoke->>PacketOperationContext: SendPoke(uin, groupUin?)
alt 提供了 group_id
PacketOperationContext->>PacketOperationContext: GroupPoke(uin, groupUin)
else 未提供 group_id
PacketOperationContext->>PacketOperationContext: FriendPoke(uin)
end
文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request implements a new action Sequence diagram for send_poke action flowsequenceDiagram
participant Client
participant SendPoke
participant PacketOperationContext
Client->>SendPoke: send_poke(user_id, [group_id])
SendPoke->>PacketOperationContext: SendPoke(uin, groupUin?)
alt group_id is provided
PacketOperationContext->>PacketOperationContext: GroupPoke(uin, groupUin)
else group_id is not provided
PacketOperationContext->>PacketOperationContext: FriendPoke(uin)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗨 @Shua-github - 我已经审查了你的更改 - 这里有一些反馈:
总体评论:
- 请使用英语作为PR标题和描述,以确保与国际社区更好的合作。
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @Shua-github - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please use English for PR titles and descriptions to ensure better collaboration with the international community.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
传入
group_id
字段按group_poke
发送 ,否则按friend_poke
发送Summary by Sourcery
新功能:
send_poke
操作以向用户发送戳。如果提供了group_id
,戳将作为群戳发送。否则,它将作为好友戳发送。Original summary in English
Summary by Sourcery
New Features:
send_poke
action to send a poke to a user. Ifgroup_id
is provided, the poke will be sent as a group poke. Otherwise, it will be sent as a friend poke.