[Feat] Seperate out create and run node methods #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-kmt
force-pushed
the
feat/seperate_out_create_and_run_node_methods
branch
from
6e385dd to
713561b
Compare
naptha_sdk/cli.py
Outdated
| # Create command | ||
| create_parser = subparsers.add_parser("create", help="Execute create command.") | ||
| create_parser.add_argument("agent", help="Select the agent to run") | ||
| create_parser.add_argument("-e", "--environment_nodes", help="Environment nodes to store data during agent runs.") |
There was a problem hiding this comment.
Should create also take worker_nodes as an arg?
| create_parser = subparsers.add_parser("create", help="Execute create command.") | ||
| create_parser.add_argument("agent", help="Select the agent to run") | ||
| create_parser.add_argument("-e", "--environment_nodes", help="Environment nodes to store data during agent runs.") | ||
|
|
There was a problem hiding this comment.
Should we remove worker_nodes and environment_nodes from the run_parser args?
…ew node endpoints
richardblythman
force-pushed
the
feat/seperate_out_create_and_run_node_methods
branch
from
b29d819 to
e3886f7
Compare
richardblythman
approved these changes
Dec 12, 2024
richardblythman
deleted the
feat/seperate_out_create_and_run_node_methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue