-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/angular13 #46
Feature/angular13 #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed yesterday, could rebase your changes and leave the "ng7" and "ng8" applications alone until you have finished migrating the ngx-form-errors
library to Angular 13 ?
Then, upgrading both to ng12 and ng13 ?
8665528
to
fa720f1
Compare
Upgrade version to angular 8
fa720f1
to
9767679
Compare
Upgrade version to angular 9
Upgrade version to angular 10
Upgrade version to angular 11
Upgrade version to angular 12
Remove tslint because the end of support. Now we are using eslint.
9767679
to
72eece8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to run the ng12 demo app:
$ npm start superitman@my-mac
> [email protected] start
> ng serve --disableHostCheck=true
Warning: Running a server with --disable-host-check is a security risk. See https://medium.com/webpack/webpack-dev-server-middleware-security-issues-1489d950874a for more information.
⠹ Generating browser application bundles (phase: building)...node:internal/crypto/hash:69
this[kHandle] = new _Hash(algorithm, xofLen);
^
Error: error:0308010C:digital envelope routines::unsupported
Could you have a look ?
this issue is due to breaking change in node17 --> this work with node 14 but not node 18 |
72eece8
to
317c9d4
Compare
Upgrade version to angular 13
317c9d4
to
bace0de
Compare
bace0de
to
0be3f36
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
run on angular 8
Issue Number: N/A
What is the new behavior?
update the library from angular 8 to angular13 and add eslint as linting engine
Does this PR introduce a breaking change?
Other information