Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/angular13 #46

Merged
merged 11 commits into from
Dec 11, 2023
Merged

Conversation

mhenkens
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

run on angular 8

Issue Number: N/A

What is the new behavior?

update the library from angular 8 to angular13 and add eslint as linting engine

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mhenkens mhenkens requested a review from SuperITMan November 21, 2023 19:19
Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed yesterday, could rebase your changes and leave the "ng7" and "ng8" applications alone until you have finished migrating the ngx-form-errors library to Angular 13 ?
Then, upgrading both to ng12 and ng13 ?

src/directives/form-errors-group.directive.spec.ts Outdated Show resolved Hide resolved
src/directives/form-errors.directive.spec.ts Outdated Show resolved Hide resolved
src/directives/form-errors.directive.spec.ts Outdated Show resolved Hide resolved
src/services/form-errors-message.service.spec.ts Outdated Show resolved Hide resolved
tsconfig.lib.json Outdated Show resolved Hide resolved
helpers.js Outdated Show resolved Hide resolved
karma.conf.js Outdated Show resolved Hide resolved
karma.conf.ci.js Outdated Show resolved Hide resolved
karma-stark.conf.js Outdated Show resolved Hide resolved
.npmrc Outdated Show resolved Hide resolved
Upgrade version to angular 9
Upgrade version to angular 10
Upgrade version to angular 11
Upgrade version to angular 12
Remove tslint because the end of support. Now we are using eslint.
Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to run the ng12 demo app:

$ npm start                                                                                                   superitman@my-mac

> [email protected] start
> ng serve --disableHostCheck=true

Warning: Running a server with --disable-host-check is a security risk. See https://medium.com/webpack/webpack-dev-server-middleware-security-issues-1489d950874a for more information.
⠹ Generating browser application bundles (phase: building)...node:internal/crypto/hash:69
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported

Could you have a look ?

demo-app/ng12/test.json Outdated Show resolved Hide resolved
demo-app/ng13/test.json Outdated Show resolved Hide resolved
demo-app/ng12/package.json Outdated Show resolved Hide resolved
demo-app/ng13/package.json Outdated Show resolved Hide resolved
@mhenkens
Copy link
Contributor Author

mhenkens commented Dec 5, 2023

I was not able to run the ng12 demo app:

$ npm start                                                                                                   superitman@my-mac

> [email protected] start
> ng serve --disableHostCheck=true

Warning: Running a server with --disable-host-check is a security risk. See https://medium.com/webpack/webpack-dev-server-middleware-security-issues-1489d950874a for more information.
⠹ Generating browser application bundles (phase: building)...node:internal/crypto/hash:69
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported

Could you have a look ?

this issue is due to breaking change in node17 --> this work with node 14 but not node 18

see https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported

package.json Outdated Show resolved Hide resolved
@SuperITMan SuperITMan merged commit e9fe926 into NationalBankBelgium:master Dec 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants