-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pass at using ag-grid for client side pagination #9
base: main
Are you sure you want to change the base?
Conversation
Tested at 43K entries. Will do further testing tomorrow on live systems. |
@ivakegg @lbschanno PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. As we talked about, it would be great to move the HTML out of our classes and use something like Thymeaf to do templating. That should already be available sine this is a spring boot (specifically, Spring MVC) application.
@@ -26,6 +28,7 @@ | |||
import io.protostuff.Message; | |||
import io.protostuff.Output; | |||
import io.protostuff.Schema; | |||
import org.apache.avro.data.Json; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an unused import? I didn't load it up in my IDE but I'm not seeing this used below.
Initial pass at using ag-grid for client side pagination. Ideally, we would move the data into an ajax call but wanted to minimize changes.