Deprecate IBaseDataObjectHelper.clone() that allows partial clones. #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambish5
previously approved these changes
Dec 3, 2024
drivenflywheel
requested changes
Dec 3, 2024
drivenflywheel
previously approved these changes
Dec 5, 2024
jpdahlke
approved these changes
Dec 5, 2024
jpdahlke
requested changes
Dec 5, 2024
Co-authored-by: jpdahlke <[email protected]>
drivenflywheel
approved these changes
Dec 5, 2024
sambish5
approved these changes
Dec 5, 2024
jpdahlke
approved these changes
Dec 5, 2024
rpg36
pushed a commit
to rpg36/emissary
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the IBaseDataObjectHelper.clone() method that allows for partial clones. Partial clones were implemented to allow cloning that matched the now deprecated BaseDataObject.clone() method. A search of the code bases did not show any instance where IBaseDataObjectHelper.clone() was called for a partial clone except for in the IBaseDataObjectHelperTest class. Therefore, only full clones seem to be needed and partial clones should be removed.