Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-compile regex in PriorityDirectoryConverter #1023

Merged
merged 1 commit into from
Dec 12, 2024
Merged

pre-compile regex in PriorityDirectoryConverter #1023

merged 1 commit into from
Dec 12, 2024

Conversation

DonResnik
Copy link
Contributor

Moved Pattern and Matcher to make class level vars to save regex complie time

@jpdahlke jpdahlke changed the title Refactor regex Pattern pre-compile regex in PriorityDirectoryConverter Dec 12, 2024
@jpdahlke jpdahlke added this to the v8.19.0 milestone Dec 12, 2024
@jpdahlke jpdahlke added the tech-debt Low-impact cleanup and upkeep label Dec 12, 2024
@jpdahlke jpdahlke merged commit 379db5e into main Dec 12, 2024
13 checks passed
@jpdahlke jpdahlke deleted the refactor-regex branch December 12, 2024 04:30
rpg36 pushed a commit to rpg36/emissary that referenced this pull request Jan 7, 2025
@DonResnik
pre-compile regex in PriorityDirectoryConverter (NationalSecurityAgen…
638b0f4 
…cy#1023)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@sambish5 sambish5 sambish5 approved these changes

Assignees
No one assigned
Labels
tech-debt Low-impact cleanup and upkeep
Projects
None yet
Milestone
v8.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DonResnik @drivenflywheel @sambish5 @jpdahlke