Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary modifier :: variables declared in try-with-resources are … #1026

Merged
merged 1 commit into from
Dec 26, 2024
Merged

unnecessary modifier :: variables declared in try-with-resources are … #1026

merged 1 commit into from
Dec 26, 2024

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Dec 17, 2024

…implicitly final

@jpdahlke
Copy link
Collaborator

Is this a rule incompatibility between errorprone and sonarlint?

@dev-mlb
Copy link
Collaborator Author

dev-mlb commented Dec 17, 2024

Is this a rule incompatibility between errorprone and sonarlint?

Found these when fixing the warnings from pmd

@jpdahlke jpdahlke added this to the v8.20.0 milestone Dec 23, 2024
@jpdahlke jpdahlke added the tech-debt Low-impact cleanup and upkeep label Dec 23, 2024
@jpdahlke jpdahlke merged commit ace38d3 into main Dec 26, 2024
13 checks passed
@jpdahlke jpdahlke deleted the twr-implicitly-final branch December 26, 2024 18:26
rpg36 pushed a commit to rpg36/emissary that referenced this pull request Jan 7, 2025
@dev-mlb
unnecessary modifier :: variables declared in try-with-resources are …
0b73a9f 
…implicitly final (NationalSecurityAgency#1026)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@fbruton fbruton fbruton approved these changes

Assignees
No one assigned
Labels
tech-debt Low-impact cleanup and upkeep
Projects
None yet
Milestone
v8.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dev-mlb @jpdahlke @drivenflywheel @fbruton