all: cannot get PrametricParam to work in Nuke 11.1 either

it crashes calling strlen() on a NULL pointer in Nofx::NofxParametricParamInstance::make_knob(DD::Image::Knob_Closure&)
NatronGitHub · Apr 30, 2018 · 5eb5904 · 5eb5904
1 parent 4885f40
commit 5eb5904
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/ColorCorrect/ColorCorrect.cpp b/ColorCorrect/ColorCorrect.cpp
@@ -1462,7 +1462,7 @@ ColorCorrectPluginFactory::describeInContext(ImageEffectDescriptor &desc,
         const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
         const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                   !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                    8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) );  // Nuke 8-10 are known to *not* support Parametric
+                                                    8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
         if (supportsParametricParameter) {
             ParametricParamDescriptor* param = desc.defineParametricParam(kParamColorCorrectToneRanges);
             assert(param);
@@ -1568,7 +1568,7 @@ ColorCorrectPluginFactory::createInstance(OfxImageEffectHandle handle,
     const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
     const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) );  // Nuke 8-10 are known to *not* support Parametric
+                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
 
     return new ColorCorrectPlugin(handle, supportsParametricParameter);
 }

diff --git a/ColorLookup/ColorLookup.cpp b/ColorLookup/ColorLookup.cpp
@@ -1746,7 +1746,7 @@ ColorLookupPluginFactory::describeInContext(ImageEffectDescriptor &desc,
     const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
     const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) );  // Nuke 8-10 are known to *not* support Parametric
+                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
 
     if (!supportsParametricParameter) {
         throwHostMissingSuiteException(kOfxParametricParameterSuite);

diff --git a/HueCorrect/HueCorrect.cpp b/HueCorrect/HueCorrect.cpp
@@ -861,7 +861,7 @@ HueCorrectPluginFactory::describeInContext(ImageEffectDescriptor &desc,
     const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
     const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) );  // Nuke 8-10 are known to *not* support Parametric
+                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
 
     if (!supportsParametricParameter) {
         throwHostMissingSuiteException(kOfxParametricParameterSuite);
@@ -1445,7 +1445,7 @@ HueKeyerPluginFactory::describeInContext(ImageEffectDescriptor &desc,
     const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
     const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) ); // Nuke 8-10 are known to *not* support Parametric
+                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
 
     if (!supportsParametricParameter) {
         throwHostMissingSuiteException(kOfxParametricParameterSuite);

diff --git a/Retime/Retime.cpp b/Retime/Retime.cpp
@@ -700,7 +700,7 @@ RetimePluginFactory::describeInContext(ImageEffectDescriptor &desc,
         const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
         const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                    !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                     8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) ); // Nuke 8-10 are known to *not* support Parametric
+                                                     8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
         if (supportsParametricParameter) {
             PageParamDescriptor* page = desc.definePageParam(kPageTimeWarp);
             if (page) {
@@ -783,7 +783,7 @@ RetimePluginFactory::createInstance(OfxImageEffectHandle handle,
     const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
     const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) );  // Nuke 8-10 are known to *not* support Parametric
+                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
 
     return new RetimePlugin(handle, supportsParametricParameter);
 }

diff --git a/TimeDissolve/TimeDissolve.cpp b/TimeDissolve/TimeDissolve.cpp
@@ -556,7 +556,7 @@ TimeDissolvePluginFactory::describeInContext(ImageEffectDescriptor &desc,
     const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
     const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) );  // Nuke 8-10 are known to *not* support Parametric
+                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
     if (supportsParametricParameter) {
         ParametricParamDescriptor* param = desc.defineParametricParam(kParamCurve);
         assert(param);
@@ -595,7 +595,7 @@ TimeDissolvePluginFactory::createInstance(OfxImageEffectHandle handle,
     const ImageEffectHostDescription &gHostDescription = *getImageEffectHostDescription();
     const bool supportsParametricParameter = ( gHostDescription.supportsParametricParameter &&
                                                !(gHostDescription.hostName == "uk.co.thefoundry.nuke" &&
-                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 10) );  // Nuke 8-10 are known to *not* support Parametric
+                                                 8 <= gHostDescription.versionMajor && gHostDescription.versionMajor <= 11) );  // Nuke 8-11.1 are known to *not* support Parametric
 
     return new TimeDissolvePlugin(handle, supportsParametricParameter);
 }