added allowNonVoiPayments feature flag #39
Conversation
Couldn't you simply hide this menu item instead of the dropdown items |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a feature flag to conditionally show non-VOI payment options in the EnvoiLayout.
- Adds
allowNonVoiPaymentsstate to control visibility of additional payment methods. - Wraps
aUSDCandUNIT<MenuItem>s behind this flag.
Comments suppressed due to low confidence (1)
src/layouts/EnvoiLayout.tsx:1339
- Add unit or integration tests to verify that the non-VOI payment options appear when
allowNonVoiPaymentsis enabled.
{allowNonVoiPayments && (
| ); | ||
| const [refreshTrigger, setRefreshTrigger] = useState(0); | ||
| const [paymentModalOpen, setPaymentModalOpen] = useState(false); | ||
| const [allowNonVoiPayments, setAllowNonVoiPayments] = useState(false); |
There was a problem hiding this comment.
The allowNonVoiPayments state is initialized but never updated, so the conditional block will never render. Hook this flag up to props, context, or a feature-flag service.
Copilot uses AI. Check for mistakes.
| ); | ||
| const [refreshTrigger, setRefreshTrigger] = useState(0); | ||
| const [paymentModalOpen, setPaymentModalOpen] = useState(false); | ||
| const [allowNonVoiPayments, setAllowNonVoiPayments] = useState(false); |
There was a problem hiding this comment.
[nitpick] Using local component state for a feature flag can lead to inconsistent behavior across the app; consider sourcing this flag from a centralized config or context.
Copilot uses AI. Check for mistakes.
No description provided.