Draft PR for review : Add physics module to Nazara (physics engine: nphysics2d) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
December 7, 2019 09:50
Fomys
reviewed
Dec 11, 2019
|
|
||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
|
||
| [dependencies] |
There was a problem hiding this comment.
Are minor versions very useful here? (thanks Lynix)
There was a problem hiding this comment.
I juste left default cargo.toml
| @@ -0,0 +1,34 @@ | |||
| extern crate nazara_physics2d; | |||
| extern crate nalgebra; | |||
| extern crate ncollide2d; | |||
There was a problem hiding this comment.
The goal is not to avoid the use of the lib ncollide and to go through Nazara2d?
| use nazara_physics2d::material::Material; | ||
|
|
||
| use nalgebra::Vector2; | ||
| use nalgebra::Point2; |
There was a problem hiding this comment.
Same thing for nalgebra I think.
There was a problem hiding this comment.
Same nphysics2d requires nalgebra
nazara_physics2d/src/lib.rs
Outdated
Comment on lines
14
to
15
| pub trait Number : From<f64> + RealField {} | ||
| impl<T> Number for T where T: From<f64> + RealField {} |
There was a problem hiding this comment.
Is putting things in lib.rs a good idea?
|
You can probably set a correct naming and description of what you're adding with this PR. ;) Btw, github has a dedicated concept for draft PR, you can check all this here: https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
Faymoon
changed the title
Faymoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.