Make Pausable use Acl for authorization #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooori
commented
Dec 7, 2022
|
As discussed offline, merging now without modifying |
mrLSD
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
Pausableplugin required a contract to beOwnableto manage authorization of (un)pausing features and to define exemptions viaexcept. This PR makesPausableuseAccessControllableinstead ofOwnable.Overview
exceptwith#[pause]or#[if_paused], developers can specify Acl role(s) which are exempted.Examples
Files in examples/pausable-examples/ have not been updated, for now. I'd propose to remove the contracts there and instead add a test contract in
/near-plugins/tests/contracts/pausable, see #48.I suggest we first decide if this is a reasonable approach before updating examples.