fix(elastic): encode duration_μs inserted by LoggerJSON.Plug as event.duration #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2024 12:12
|
@AndrewDryga This basically fixes the Elastic equivalent of #124 Would you mind reviewing? 😊 |
|
Please see #124 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. While trying out
LoggerJSON.PlugI noticed that it addsduration_μsas metadata, but this is not a valid field in the Elastic Common Schema, so here's a quick fix to remap that toevent.durationas is also recommended on the Elastic forumNote that similar changes might be necessary for the Google Cloud and Datadog formatters too.