-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release(prod): 2021.11.11.0-1, ECC concurrency, initFile robustness, and pktfwd rewrite #215
Merged
vpetersson
merged 24 commits into
production
from
marvinmarnold/prod/ecc-initFile-fixes
Nov 15, 2021
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a0b4e52
test diag with new base image
shawaj 6c71285
bump upnp for testing
shawaj 5b042f2
fix: add depends on for packet forwarder
shawaj 2eca2c9
Merge pull request #185 from NebraLtd/shawaj/waitforminer
shawaj 06abcb7
Create docker-compose.yml
shawaj f1e275e
Bump to 2021.10.27.0_GA
shawaj a2cd325
Added documentation to the readme for quick start (#189)
06dcde3
Bump to 2021.10.29.0_GA
shawaj 2193dc3
Bump to 2021.11.02.0_GA
shawaj b1a1710
rearrange readme
shawaj c3a1f31
Update README.md
shawaj 11a539b
Bump diag and config
shawaj 175e06f
feat: bump GA to 2021.11.04.2
marvinmarnold c5a299d
Merge pull request #195 from NebraLtd/marvinmarnold/193/GA-2021-11-04-2
marvinmarnold ec34b65
release: bump GA to 2021.11.10.0
marvinmarnold 64ef524
Merge pull request #205 from NebraLtd/marvinmarnold/testnet/GA-2021-1…
marvinmarnold 4a5b2eb
release: bump GA to 2021.11.11.0
marvinmarnold 8394e47
Merge pull request #211 from NebraLtd/marvinmarnold/testnet/GA-2021-1…
marvinmarnold 5973e3e
Add tech support to CODEOWNERS
shawaj 2bcf89e
fix: ECC locking and initFile (#209)
marvinmarnold 10dd378
Merge pull request #213 from NebraLtd/shawaj/CODEOWNERS
shawaj 0a3f8f8
build: bump firmware version
marvinmarnold 41f8ed7
Merge remote-tracking branch 'origin/production' into marvinmarnold/p…
marvinmarnold 504a3e7
bump(pktfwd): current master branch
marvinmarnold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,33 @@ Repo: [github.com/balenablocks/dbus](https://github.com/balenablocks/dbus) | |
|
||
This container configures a DBus session bus instance that is used by the gateway config container to communicate with the miner code (note that there is also a separate system bus running on the host OS which is used by gateway config to communicate with bluez for configuring Bluetooth services). This removes the need to have a custom `com.helium.Miner.conf` dbus config file on the host OS as was done previously (and meant we had to run a custom balena device type). | ||
|
||
# Quick Start | ||
|
||
This is a guide to help you get started with the repository and get it running on your local device. This guide is focused on pushing the repository onto a Raspberry Pi using Balena. | ||
|
||
**Prerequisites:** | ||
- Local Test Device (Ex: Raspberry Pi) | ||
- Computer for development and pushing to the device | ||
- Git installed - [download here](https://git-scm.com/downloads) | ||
- [Balena CLI](https://github.com/balena-io/balena-cli) (Install located on Balena step in quick start steps below) | ||
|
||
### Quick Start Steps | ||
|
||
**Step 1:** Clone the repository to your local machine using one of the following commands: | ||
- HTTP: `git clone https://github.com/NebraLtd/helium-miner-software.git` | ||
- SSH: `git clone [email protected]:NebraLtd/helium-miner-software.git` | ||
|
||
**Step 2:** Follow the [getting started guide](https://www.balena.io/docs/learn/getting-started/raspberrypi3/nodejs/) for Balena to help you install Balena on your local test device and get a fleet setup so you can start pushing code to it. | ||
|
||
**Step 3:** Once you've gone through the steps and have Balena setup with your device in your fleet, open your cli terminal and navigate to the root directory of the cloned repository (Ex: /usr/name/documents/helium-miner-software). | ||
|
||
**Step 4:** Once you're at the root directory. You want to push the code by running the following command: | ||
```bash | ||
$ balena push <fleet-name> | ||
``` | ||
|
||
**Step 5:** Once complete check your fleet on the Balena dashboard and all modules should be running on the local test device. | ||
|
||
# Device Configuration / Fleet Configuration Notes | ||
|
||
For some Nebra Hotspots that use spidev1.2 you may need to add a DT overlay in the device or fleet configuration section on balenaCloud to enable spi1. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to ensure that this non standard version number layout doesn't cause any issues with diagnostics and config
Don't see why it would, but just in case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the way we've done it in the past?
2021.11.11.0.1
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been 2021.11.11.1
I think your way is the best. Just want to make sure it doesn't cause any issues with anything. Can't see why it would in particular was just a thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We treat it as a string, so this really shouldn't cause any issues and it has passed QA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpetersson we didn't QA it with this version number...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KevinWassermann94 can you check some production devices to see that the version number hasn't caused any issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawaj Should be covered in the QC playbook already (correct me if i'm wrong @KevinWassermann94).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawaj I am waiting for the production to update.
@vpetersson We should add a term to the GA playbook that no further commits should be pushed to a PR without testing them on the testnet first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KevinWassermann94 we can solve that by signing off a particular commit hash.