Add light hotspot automation #411

MuratUrsavas · 2022-03-28T18:17:16Z

Issue
#399

Summary:
Adapting all automation to light hotspots.

How

Removed dbus, hm-miner container references
Added hm-gatewayrs references

Checklist

Tests added
Cleaned up commit history (rebase!)
Documentation added
Thought about variable and method names

(#399)

marvinmarnold · 2022-03-28T20:09:24Z

.github/workflows/push-to-prod-draft.yml

@@ -74,13 +46,13 @@ jobs:
        if: matrix.sbc == 'rockpi' && success()
        with:
          balena_api_token: ${{secrets.BALENA_API_TOKEN}}
-          balena_command: "deploy nebraltd/helium-${{ matrix.variant }}-${{ matrix.frequency }}${{ env.ROCKPI }} --logs --debug --nocache --build --draft"
+          balena_command: "deploy nebraltd/helium${{ env.ROCKPI }} --logs --debug --nocache --build --draft"


Can you remind me where env.ROCKPI is being set and what values it takes on?

helium-miner-software/.github/workflows/push-to-prod-draft.yml

Line 28 in 81fb2ef

ROCKPI="-rockpi"

marvinmarnold · 2022-03-28T20:12:19Z

.github/workflows/push-to-prod-draft.yml

      - name: Balena Deploy (Nebra RasPi)
        uses: nebraltd/[email protected]
        if: matrix.sbc == 'raspi' && success()
        with:
          balena_api_token: ${{secrets.BALENA_API_TOKEN_1}}
-          balena_command: "deploy nebraltd/helium-${{ matrix.variant }}-${{ matrix.frequency }} --logs --debug --nocache --build --draft"
+          balena_command: "deploy nebraltd/helium-light-hotspot --logs --debug --nocache --build --draft"


Should this be helium-light-test? I'm currently using helium-light-hotspot to test this flow which is different.

This was for production, not testnet.

marvinmarnold · 2022-03-28T20:13:52Z

.github/workflows/push-to-prod-draft.yml

@@ -10,34 +10,6 @@ jobs:
      fail-fast: false
      matrix:
        sbc: [raspi, rockpi, rak, pisces, og, sensecap, finestra, controllino]
-        frequency: [470, 868, 915]


Do we really want to touch the prod workflows? Won't those be unchanged?

We're removing indoor outdoor variants and all frequencies. So, not needed to keep all of matrix rows.

I think we had decided that fleet reorganization will be separate ticket. if that matter has been settled, then its good.

marvinmarnold · 2022-03-28T20:17:08Z

.github/workflows/push-to-testnet-draft.yml

@@ -41,19 +41,19 @@ jobs:
        if: matrix.sbc == 'rockpi' && success()
        with:
          balena_api_token: ${{secrets.BALENA_API_TOKEN}}
-          balena_command: "deploy nebraltd/helium-testnet${{ env.ROCKPI }} --logs --debug --nocache --build --draft"
+          balena_command: "deploy nebraltd/helium-light-testnet${{ env.ROCKPI }} --logs --debug --nocache --build --draft"


What about consolidating all of these into a single alena_command: "deploy nebraltd/helium-light-testnet-${{ matrix.sbc }} --logs --debug --nocache --build --draft"?

Why do we need more than one testnet for light? Probably overkill just for testing

Also it should be helium-light-test fleet that already exists

Take a look at the light-hotspot-software repo

What about consolidating all of these into a single alena_command: "deploy nebraltd/helium-light-testnet-${{ matrix.sbc }} --logs --debug --nocache --build --draft"?

That could be possible. Let me think about our reasons to keep it separate.

It was my idea. We'll need to have separate fleets for every device type. I thought it has to mimic the same environment for testing. Also this is a one time setup. Otherwise, we'll be chasing different things for each device on testnet. That could need more effort than this one. At least this was my humble opinion.

Also it should be helium-light-test fleet that already exists

Take a look at the light-hotspot-software repo

OK. I can use helium-light-test. But AFAIK we had abondoned light-sotspot-software and using light-hotspot branch of helium-miner-software?

Yes we are, but essentially we are migrating from that older repo to this one to make it easier for us to merge this to master branch when it goes live.

So it needs to be done in a way which can easily be merged with master further down the line.

Also, we aren't going to move devices to new fleets for light. We will just update the existing fleets with the newer software, when the time comes

shawaj · 2022-03-29T01:24:01Z

IIRC GitHub actions workflows will only work from the master branch

shawaj · 2022-03-29T01:27:43Z

Some of this is duplicated in #409

Also you can't rename the helium-miner container in the yml file or it will break packet forwarder and hm-pyhelper I think

shawaj · 2022-03-29T01:30:18Z

templates/docker-compose.template

    restart: always
    privileged: true
    volumes:
      - pktfwdr:/var/pktfwd
    environment:
      - FIRMWARE_VERSION={{FIRMWARE_VERSION}}

-  helium-miner:
-    image: nebraltd/hm-gatewayrs:{{GATEWAY_VERSION}}
+  gateway-rs:


See comment about why this can't be changed

It shouldn't be a problem, but I'm not sure. I've removed the dependency, but will make sure packet-forwarder doesn't fail.

we will have to keep helium-miner. it will need changes at too many places. Not important right now.

Yeah it would need changing in packet forwarder and in hm-pyhelper and not worth the effort.

Also having it called helium-miner is still technically correct

shawaj · 2022-03-29T01:30:48Z

templates/docker-compose.template

    environment:
      - FIRMWARE_VERSION={{FIRMWARE_VERSION}}
      - FIRMWARE_SHORT_HASH={{ENV.FIRMWARE_SHORT_HASH}}
      - DIAGNOSTICS_VERSION={{DIAGNOSTICS_VERSION}}
-      - DBUS_SYSTEM_BUS_ADDRESS=unix:path=/host/run/dbus/system_bus_socket


This is still required

I wasn't sure about that. @pritamghanghas What do you think?

system bus is still needed.

I think we need it for Bluetooth / LTE / WiFi

shawaj · 2022-03-29T01:32:37Z

templates/docker-compose.template

    environment:
      - FIRMWARE_VERSION={{FIRMWARE_VERSION}}
      - FIRMWARE_SHORT_HASH={{ENV.FIRMWARE_SHORT_HASH}}
-      - DBUS_SYSTEM_BUS_ADDRESS=unix:path=/host/run/dbus/system_bus_socket
-      - DBUS_SESSION_BUS_ADDRESS=unix:path=/session/dbus/session_bus_socket


System bus is still required I believe

Same as above. This was a thing I'd like to discuss while the PR is open.

shawaj · 2022-03-29T01:32:52Z

templates/docker-compose.template

    labels:
      io.balena.features.sysfs: 1
      io.balena.features.kernel-modules: 1
-      io.balena.features.dbus: 1


System bus still needed I think

shawaj · 2022-03-29T01:33:42Z

templates/docker-compose.template

@@ -79,19 +71,7 @@ services:
    labels:
      io.balena.features.sysfs: 1
      io.balena.features.procfs: 1
-      io.balena.features.dbus: 1


Still needed

vpetersson · 2022-03-29T06:54:37Z

IIRC GitHub actions workflows will only work from the master branch

No this isn't true. You can run them on any branch. We already do this in multiple repos.

shawaj · 2022-03-29T14:20:50Z

IIRC GitHub actions workflows will only work from the master branch

No this isn't true. You can run them on any branch. We already do this in multiple repos.

@vpetersson you can't run scheduled actions from anything but master branch

They can run on another branch. But the workflow itself has to be stored in master branch for it to appear in the "actions" tab and for you to be able to do scheduled, repository dispatch or workflow dispatch based actions.

* update hm-diag hash containing this message.

feat: Messaging for disabled blockchain sync #411

Murat Ursavas added 2 commits March 28, 2022 19:24

Added light hotspot automation

527c1da

(#399)

Merged latest changes from light-hotspot

81fb2ef

MuratUrsavas requested review from a team as code owners March 28, 2022 18:17

MuratUrsavas marked this pull request as draft March 28, 2022 18:19

MuratUrsavas changed the base branch from master to light-hotspot March 28, 2022 18:19

MuratUrsavas marked this pull request as ready for review March 28, 2022 18:20

MuratUrsavas changed the title ~~Murat/light hotspot automation~~ Add light hotspot automation Mar 28, 2022

marvinmarnold reviewed Mar 28, 2022

View reviewed changes

shawaj reviewed Mar 29, 2022

View reviewed changes

MuratUrsavas closed this Mar 30, 2022

MuratUrsavas deleted the murat/light-hotspot-automation branch March 30, 2022 06:30

pritamghanghas added a commit that referenced this pull request Jul 15, 2022

feat: Messaging for disabled blockchain sync #411

e88a6b9

* update hm-diag hash containing this message.

pritamghanghas added a commit that referenced this pull request Jul 15, 2022

Merge pull request #496 from NebraLtd/pritam/release_2022.07.14.0-2

d2ae12b

feat: Messaging for disabled blockchain sync #411

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add light hotspot automation #411

Add light hotspot automation #411

MuratUrsavas commented Mar 28, 2022

marvinmarnold Mar 28, 2022

shawaj Mar 29, 2022

marvinmarnold Mar 28, 2022

MuratUrsavas Mar 29, 2022

marvinmarnold Mar 28, 2022

MuratUrsavas Mar 29, 2022

pritamghanghas Mar 29, 2022

marvinmarnold Mar 28, 2022

shawaj Mar 29, 2022

shawaj Mar 29, 2022

MuratUrsavas Mar 29, 2022

MuratUrsavas Mar 29, 2022

MuratUrsavas Mar 29, 2022

shawaj Mar 29, 2022

MuratUrsavas Mar 30, 2022

shawaj commented Mar 29, 2022

shawaj commented Mar 29, 2022 •

edited

Loading

shawaj Mar 29, 2022

MuratUrsavas Mar 29, 2022

pritamghanghas Mar 29, 2022

shawaj Mar 29, 2022

shawaj Mar 29, 2022

MuratUrsavas Mar 29, 2022

pritamghanghas Mar 29, 2022

shawaj Mar 29, 2022

shawaj Mar 29, 2022

MuratUrsavas Mar 29, 2022

shawaj Mar 29, 2022

MuratUrsavas Mar 29, 2022

shawaj Mar 29, 2022

MuratUrsavas Mar 29, 2022

vpetersson commented Mar 29, 2022

shawaj commented Mar 29, 2022 •

edited

Loading

Add light hotspot automation #411

Add light hotspot automation #411

Conversation

MuratUrsavas commented Mar 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shawaj commented Mar 29, 2022

shawaj commented Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vpetersson commented Mar 29, 2022

shawaj commented Mar 29, 2022 • edited Loading

shawaj commented Mar 29, 2022 •

edited

Loading

shawaj commented Mar 29, 2022 •

edited

Loading