Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sx1302: upgrade hal to v2.1.0 #40

Merged
merged 3 commits into from
Oct 5, 2021
Merged

sx1302: upgrade hal to v2.1.0 #40

merged 3 commits into from
Oct 5, 2021

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Aug 26, 2021 •
edited
Loading

Why

upgrade to v2.1.0 version of sx1302_hal so we are on the latest

How

upgrade hal to v2.1.0

  • bring in latest repo from upstream
  • update dockerfile
  • update build script
  • update sx1302 fixes (see sx1302 fixes? #23) for updated repo
  • remove some unecessary files and code
  • update config.json files to add com_type and com_path and fine_timestamping

References

Closes: #24
Closes: #42
Relates-to: #23

@shawaj shawaj requested a review from a team as a code owner August 26, 2021 00:18
@shawaj
Copy link
Member Author

shawaj commented Aug 26, 2021

Testing on light hotspots - will report back - NebraLtd/light-hotspot-software@ddbd553

@shawaj
Copy link
Member Author

shawaj commented Aug 26, 2021

Working fine on lights - but need to pull in new config.json changes

@shawaj
Copy link
Member Author

shawaj commented Aug 26, 2021 •
edited
Loading

all pulled in now and tested - ready for review 👍

@shawaj
sx1302: upgrade hal to v2.1.0
41209c6 
upgrade hal to v2.1.0
- bring in latest repo from upstream
- update dockerfile
- update build script
- update sx1302 fixes (see #23) for updated repo
- remove some unecessary files and code
- update config.json files to add com_type and com_path and fine_timestamping

Closes: #24
@shawaj
Copy link
Member Author

shawaj commented Oct 4, 2021

FYI this is a required update for us to be able to support sx1303 chipset.

Will sort the merge conflicts shortly

@robputt
Copy link
Contributor

robputt commented Oct 4, 2021

Looks good other than merge conflicts.

@shawaj shawaj mentioned this pull request Oct 5, 2021
Closed
@shawaj shawaj merged commit 2c9278c into master Oct 5, 2021
@shawaj shawaj deleted the shawaj/sx1302hal branch October 5, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robputt robputt robputt approved these changes

Assignees
No one assigned
Labels
hide sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sx1303 support Why are we using v1.0.5 of sx1302_hal?
3 participants
@shawaj @robputt @marvinmarnold