Refactor build process #59
+649
−7,980
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,114 +1,88 @@ | ||
| # Packet Forwarder Docker File | ||
| # (C) Nebra Ltd 2021 | ||
| # Licensed under the MIT License. | ||
|
|
||
| #################################################################################################### | ||
| ########################### Stage: PktFwd Python App Builder ####################################### | ||
| FROM balenalib/raspberry-pi-debian:buster-build as pktfwd-builder | ||
|
|
||
| # Variables used internally to this stage | ||
| ENV INPUT_DIR=/opt/input | ||
|
|
||
| # Variables to be referenced pktfwd-runner stage | ||
| ENV OUTPUT_DIR=/opt/output/pktfwd-dependencies | ||
|
|
||
| WORKDIR "$INPUT_DIR" | ||
|
|
||
| # Install python3 and pip3 | ||
| # hadolint ignore=DL3008 | ||
| RUN apt-get update && \ | ||
| apt-get -y install --no-install-recommends \ | ||
| python3=3.7.3-1 \ | ||
| python3-pip=18.1-5+rpt1 && \ | ||
| apt-get autoremove -y && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Copy python dependencies for `pip3 install` later | ||
| COPY requirements.txt requirements.txt | ||
|
|
||
| RUN pip3 install --target="$OUTPUT_DIR" --no-cache-dir -r requirements.txt | ||
| # TODO remove once published | ||
| RUN pip3 install setuptools wheel | ||
marvinmarnold marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| RUN pip3 install --target="$OUTPUT_DIR" git+https://github.com/NebraLtd/hm-pyhelper@marvinmarnold/fix-logger-packaging --upgrade --no-cache-dir | ||
|
|
||
| ################################################################################################### | ||
| ################################## Stage: runner ################################################## | ||
| FROM balenalib/raspberry-pi-debian:buster-run as pktfwd-runner | ||
shawaj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ENV ROOT_DIR=/opt | ||
|
|
||
| # Copy from: Locations of build assets within images of earlier stages | ||
| ENV SX1301_LORA_GATEWAY_OUTPUT_RESET_LGW_FILEPATH=/opt/output/reset_lgw.sh | ||
| ENV SX1301_PACKET_FORWARDER_OUTPUT_DIR=/opt/output | ||
| ENV SX1302_HAL_OUTPUT_DIR=/opt/output | ||
| ENV PKTFWD_BUILDER_OUTPUT_DIR=/opt/output/pktfwd-dependencies | ||
|
|
||
| # Copy to: Locations build assets from earlier stages/source are copied into | ||
| ENV SX1301_DIR="$ROOT_DIR/sx1301" | ||
| ENV SX1302_DIR="$ROOT_DIR/sx1302" | ||
| ENV PYTHON_APP_DIR="$ROOT_DIR/pktfwd" | ||
| ENV PYTHON_DEPENDENCIES_DIR="$ROOT_DIR/pktfwd-dependencies" | ||
| ENV SX1301_RESET_LGW_FILEPATH="$SX1301_DIR/reset_lgw.sh" | ||
|
|
||
| # Variables required for pktfwd python app | ||
| ENV SX1301_REGION_CONFIGS_DIR="$PYTHON_APP_DIR/config/lora_templates_sx1301" | ||
| ENV SX1302_REGION_CONFIGS_DIR="$PYTHON_APP_DIR/config/lora_templates_sx1302" | ||
| ENV SX1302_LORA_PKT_FWD_FILEPATH="$SX1302_DIR/lora_pkt_fwd" | ||
|
|
||
| WORKDIR "$ROOT_DIR" | ||
|
|
||
| # Copy python app | ||
| COPY pktfwd/ "$PYTHON_APP_DIR" | ||
|
|
||
| # Copy sx1301 lora_pkt_fwd_SPI_BUS | ||
| COPY --from=nebraltd/packet_forwarder:83fd72d2db4c69faffd387d757452cbe9d594a08 "$SX1301_PACKET_FORWARDER_OUTPUT_DIR" "$SX1301_DIR" | ||
|
There was a problem hiding this comment. Should update these all to the master versions in other repos before merging |
||
|
|
||
| # Copy sx1301 reset_lgw.sh | ||
shawaj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| COPY --from=nebraltd/lora_gateway:9c4b1d0c79645c3065aa4c2f3019c14da6cb2675 "$SX1301_LORA_GATEWAY_OUTPUT_RESET_LGW_FILEPATH" "$SX1301_RESET_LGW_FILEPATH" | ||
|
|
||
| # Copy sx1302 chip_id, reset_lgw, and lora_pkt_fwd | ||
| COPY --from=nebraltd/sx1302_hal:3d73e6af43535f700ff7b6c2b49cc79d388cd70f "$SX1302_HAL_OUTPUT_DIR" "$SX1302_DIR" | ||
|
|
||
| # Copy pktfwd python app dependencies | ||
| COPY --from=pktfwd-builder "$PKTFWD_BUILDER_OUTPUT_DIR" "$PYTHON_DEPENDENCIES_DIR" | ||
|
|
||
| # hadolint ignore=DL3008 | ||
| # Install python3 then cleanup | ||
| RUN apt-get update && \ | ||
| apt-get -y install --no-install-recommends python3=3.7.3-1 && \ | ||
| apt-get autoremove -y && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Add python dependencies to PYTHONPATH | ||
| ENV PYTHONPATH="${PYTHONPATH}:${PYTHON_DEPENDENCIES_DIR}" | ||
|
|
||
| # Run pktfwd/__main__.py | ||
| ENTRYPOINT ["python3", "pktfwd"] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During a recent engineering call, we decided not to use venv moving forward. The overall feeling is that Docker is already portable so venv is an unnecessary level of encapsulation. One advantage of the venv is that the python version is also copied.