feat: copy process from hm-pktfwd #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinmarnold
commented
Oct 18, 2021
marvinmarnold
force-pushed
the
marvinmarnold/independent-build
branch
2 times, most recently
from
d690c94 to
4efe2cc
Compare
- Deleted unnecessary files and copied in modified versions where needed. - Did not copy test_loragw_gps.c or test_loragw_gps_i2c.c because loragw_gps.c is not being used. - Modified reset_lgw.sh according to what was in hm-pktfwd. hm-pktfwd: https://github.com/NebraLtd/hm-pktfwd/blob/76897fd64383f849b21dabbb0f26558535a95f40/buildfiles/compileSX1302.sh#L5 loragw_gps discussion: NebraLtd/hm-pktfwd#23 (comment)
marvinmarnold
force-pushed
the
marvinmarnold/independent-build
branch
from
4efe2cc to
acc0770
Compare
Copy all files that will be needed by hm-pktfwd to an output directory. This is more similar to how packet_forwarder and lora_gateway already work. This also reduces the complexity of the build logic in hm-pktfwd.
shawaj
reviewed
Oct 20, 2021
We may need to add these back in again in the future with our updated sx1303 based concentrator but not necessary for now as we don't use the GPS currently |
shawaj
requested changes
Oct 21, 2021
marvinmarnold
force-pushed
the
marvinmarnold/independent-build
branch
from
f162a78 to
59c20a6
Compare
- Allow, but do not require reset_lgw to accept a second parameter for the reset pin.
marvinmarnold
force-pushed
the
marvinmarnold/independent-build
branch
from
59c20a6 to
bea966a
Compare
Use MSG_DEBUG to selectively output concentrator temperature.
It makes most sense if reset_lgw.sh is a standalone script influenced by both sx1301 and all sx130x variants, but it is distinct enough from any specific version that the code should be in a separate repo. Additional context: https://github.com/NebraLtd/sx1302_hal/pull/1/files#r733253225
shawaj
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The hm-pktfwd build process is confusing. Instead of building lora_gateway, packet_forwarder, and sx1302_hal in a single Dockerfile, this is being broken up into a Dockerfile per repo.
This will remain a draft until testing is complete in hm-pktfwd.
How
References