Breaking up some of lefthand.dmi and righthand.dmi. #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
work in progress
MistakeNot4892
force-pushed
the
inhands
branch
3 times, most recently
from
79b0e41
to
29ca075
Compare
MistakeNot4892
force-pushed
the
inhands
branch
from
29ca075
to
20db735
Compare
MistakeNot4892
force-pushed
the
inhands
branch
from
20db735
to
edf55f7
Compare
| @@ -17,8 +17,10 @@ | |||
| . = ..() | |||
| underlays.Cut() | |||
| if(syringe) | |||
| underlays += image(syringe.icon, src, syringe.icon_state) | |||
| underlays += syringe.filling | |||
| var/mutable_appearance/MA = syringe.appearance | |||
There was a problem hiding this comment.
Are pixel_x and pixel_y cleared? Would they even apply anyway?
There was a problem hiding this comment.
if(randpixel)
pixel_z = randpixel //an idea borrowed from some of the older pixel_y randomizations. Intended to make items appear to drop at a characterLooks like pixel_z should also be cleared. :(
EDIT: Maybe pixel_w too, at this point.
| icon_state = "hypo" | ||
| icon = 'icons/obj/hypospray.dmi' | ||
| icon_state = ICON_STATE_WORLD | ||
| abstract_type = /obj/item/chems/hypospray |
There was a problem hiding this comment.
Isn't it convention for abstract_type to come first, i.e. before name =? That makes it clearer that it's abstract.
There was a problem hiding this comment.
I wasn't aware we had a convention for that
There was a problem hiding this comment.
Per Discord, leaving it where it is, but I readded a comment.
MistakeNot4892
changed the title
MistakeNot4892
force-pushed
the
inhands
branch
from
edf55f7
to
cf1a50f
Compare
out-of-phaze
requested changes
Oct 23, 2023
| @@ -17,8 +17,10 @@ | |||
| . = ..() | |||
| underlays.Cut() | |||
| if(syringe) | |||
| underlays += image(syringe.icon, src, syringe.icon_state) | |||
| underlays += syringe.filling | |||
| var/mutable_appearance/MA = syringe.appearance | |||
There was a problem hiding this comment.
if(randpixel)
pixel_z = randpixel //an idea borrowed from some of the older pixel_y randomizations. Intended to make items appear to drop at a characterLooks like pixel_z should also be cleared. :(
EDIT: Maybe pixel_w too, at this point.
out-of-phaze
added
awaiting author
MistakeNot4892
force-pushed
the
inhands
branch
from
cf1a50f
to
8645f5a
Compare
MistakeNot4892
added
ready for review
out-of-phaze
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Deletes several unused states from lefthand/righthand.dmi.
Reworks various items to use the single icon system instead.
Why and what will this PR improve
Someday I want to destroy righthand.dmi and lefthand.dmi and this is needed for that.
Authorship
Myself.
Changelog
Nothing player-facing.