-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted ZAS fixes #4027
Assorted ZAS fixes #4027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes all look good to me and you justified/explained the ones I was confused about on Discord, so looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Discord, issues with elevators need to be sorted out.
Description of changes
An assortment of ZAS fixes, mostly related to the creation of unsimulated edges between zones and space.
zone_membership_candidate
variable has changed toFALSE
during a turf change. Every other case should be covered by the typical checks for exterior atmosphere participation.open_turf
for flooring and natural flooring to airless variants of open space. This fixes a bug where space tiles weren't being removed from Z-stacks when the bottom most space tile was replaced by plating. I haven't tested how this affects issue Multiz shuttles replace open turfs with space. #3999 yet.Doors and other atoms that need to update ZAS connections will now update theirSupplanted by new update code.loc
's neighbors if the atom is located on top of an exterior turf. This fixes a bug where unsimulated edges weren't being updated or created as expectedNew Changes 06/08/2024
SSair.mark_for_update
on non-ZAS participating turfs to create the appropriate unsimulated edgeskeep_air = TRUE
to a variety of ChangeTurf calls where appropriateAs a consequence of these changes,
keep_air_below
has been cut entirely.Why and what will this PR improve
Fixes a variety of ZAS issues stemming from the simulated/unsimulated turf merger. There is still an issue with gas conservation when merging two zones between z-levels, which I still need to resolve.
Authorship
Myself. Thanks to Penny for the multi-Z
get_dir
code.Changelog
🆑
bugfix: Fixed space tiles not creating vacuums in certain conditions
/:cl: