Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modpacking wizard, merging spells and ability_master into ability extension. #4217

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Jul 16, 2024

Extremely WIP.

  • Deletes ability_handler and associated screen element.
  • Adds generalized handling for ability and screen elements to /datum/extension/abilities.
  • Adds generalized hooks to ability extension where appropriate for ability updates.
  • Moves wizard mode, antag and various props/spells/outfits into a modpack.
  • Converts /spell type to a subtype of a generalized ability decl/metadatum system.
  • Reimplement cult spells.
  • Update deity spell code.
  • Update scroll, contract and spellbook type to behave correctly with their inherited behavior.
  • Makes sure all this stuff actually works.

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label Jul 16, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the rework/spells branch 6 times, most recently from af75d42 to d08c1df Compare August 20, 2024 10:27
@MistakeNot4892
Copy link
Contributor Author

MistakeNot4892 commented Aug 22, 2024

This has turned into something like four PRs mashed into one.

  • Stamps rewrite/generalization.
  • Scroll repath onto /paper and paper generalization.
  • Staffs, canes and brooms rewrite, stance support generalization.
  • Broom sweeping mechanics.
  • Ability system expansion and rewrite.
  • Wizard spell conversion to abilities and modpacking.

Someday I may finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress This PR is under development and shouldn't be merged.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants