Optimize floor decals #4387
Draft
Optimize floor decals #4387
+36
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
added
the
work in progress
|
Once the other two opt PRs are in, I'd like to benchmark this to get an idea of how much benefit there actually is, given the Discord discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes split out from #4186 because they were contentious enough to block that PR for months.
Need to find a way to make decals layer over natural turfs without preventing you from building on them (
is_platingis insufficient).Why and what will this PR improve
Optimizes floor decals by making them skip Initialize and Destroy logic because, well, they don't need it.
Fixes a bug where floor decals wouldn't show up on natural turfs.
Authorship
Me.