Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB IGNORE] Moving broken/burned icons onto the flooring decl. #4555

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

MistakeNot4892
Copy link
Contributor

Allows flooring decls to validate or override broken/burned states on a per-icon basis. Needs testing.

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label Nov 10, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the rework/floor_damage branch 2 times, most recently from 99a538d to 6a7f8da Compare November 10, 2024 07:26
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels Nov 11, 2024
@MistakeNot4892
Copy link
Contributor Author

Tested via explosion and fire on Tradeship.

@out-of-phaze
Copy link
Member

Tested via explosion and fire on Tradeship.

was it tested with wood floor tiles? previously it only worked for tile

@MistakeNot4892
Copy link
Contributor Author

It's only set up on plating and tiles. Wood etc don't have broken states defined currently and will need them added.

@MistakeNot4892 MistakeNot4892 changed the title Moving broken/burned icons onto the flooring decl. [MDB IGNORE] Moving broken/burned icons onto the flooring decl. Nov 12, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the rework/floor_damage branch 3 times, most recently from 3cc3a13 to c8397da Compare November 12, 2024 06:16
@MistakeNot4892 MistakeNot4892 force-pushed the rework/floor_damage branch 2 times, most recently from d7818d4 to 7b30e72 Compare November 12, 2024 07:28
out-of-phaze
out-of-phaze previously approved these changes Nov 12, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the rework/floor_damage branch 3 times, most recently from 5990311 to dd2e9a8 Compare November 12, 2024 09:00
@MistakeNot4892 MistakeNot4892 force-pushed the rework/floor_damage branch 2 times, most recently from 024c0ac to aad089c Compare November 12, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants