-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDB IGNORE] Moving broken/burned icons onto the flooring decl. #4555
Open
MistakeNot4892
wants to merge
8
commits into
NebulaSS13:dev
Choose a base branch
from
MistakeNot4892:rework/floor_damage
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
the
work in progress
This PR is under development and shouldn't be merged.
label
Nov 10, 2024
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
2 times, most recently
from
November 10, 2024 07:26
99a538d
to
6a7f8da
Compare
MistakeNot4892
added
ready for review
This PR is ready for review and merge.
and removed
work in progress
This PR is under development and shouldn't be merged.
labels
Nov 11, 2024
Tested via explosion and fire on Tradeship. |
was it tested with wood floor tiles? previously it only worked for tile |
It's only set up on plating and tiles. Wood etc don't have broken states defined currently and will need them added. |
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
from
November 12, 2024 04:40
6a7f8da
to
f30d967
Compare
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
from
November 12, 2024 04:41
f30d967
to
d2f7b8e
Compare
MistakeNot4892
changed the title
Moving broken/burned icons onto the flooring decl.
[MDB IGNORE] Moving broken/burned icons onto the flooring decl.
Nov 12, 2024
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
from
November 12, 2024 04:50
1a2453e
to
1bc75f7
Compare
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
3 times, most recently
from
November 12, 2024 06:16
3cc3a13
to
c8397da
Compare
out-of-phaze
requested changes
Nov 12, 2024
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
2 times, most recently
from
November 12, 2024 07:28
d7818d4
to
7b30e72
Compare
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
from
November 12, 2024 07:39
7b30e72
to
8fb0654
Compare
out-of-phaze
previously approved these changes
Nov 12, 2024
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
3 times, most recently
from
November 12, 2024 08:21
dc33136
to
5425a36
Compare
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
3 times, most recently
from
November 12, 2024 09:00
5990311
to
dd2e9a8
Compare
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
2 times, most recently
from
November 12, 2024 10:01
024c0ac
to
aad089c
Compare
MistakeNot4892
force-pushed
the
rework/floor_damage
branch
from
November 12, 2024 11:14
aad089c
to
85cb31d
Compare
out-of-phaze
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows flooring decls to validate or override broken/burned states on a per-icon basis. Needs testing.