Implementing Doe's new banners and signs. #4582
Conversation
MistakeNot4892
changed the title
There was a problem hiding this comment.
presumably at some point modpacks should be able to add additional banner icons, e.g. corporate logos as decals in the corporate modpack, holy symbols as decals in the mundane/modern earth modpack, etc.
would also be nice to, in the future, have it list decals on examine, including their color if supported. "This is a <font color="white">banner</font> with a <font color="red">sword</span> embroidered on it.", `"This is a walnut sign with a beer mug embroidered on it." etc.
for now this looks good, might be worth adding a unit test in the future that checks if the various states exist for every banner type's base_icon_state, like banner-hanging etc.
| I.color = banner.color | ||
| add_overlay(I) | ||
|
|
||
| if(banner.trim_color) |
There was a problem hiding this comment.
kind of feel like the decals should be added to the banner state first, with BLEND_INSET_OVERLAY, and then we apply the trim on top to keep the layering sane. that way you could have user-added decals like stripes/crosses/etc that aren't mutually exclusive with other decals and work regardless of banner shape. this probably works fine as-is i just wanted to point out that inset overlay blend mode could be useful here now or in the future
Symbols are now decls, so this is done. Simple version of this is done. |
MistakeNot4892
force-pushed
the
feature/banners
branch
from
7311a48
to
d19df16
Compare
Random debug types to show the concepts:
Icons by @PlayerDeer.