Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intents are now /decl/intent. #4585

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

MistakeNot4892
Copy link
Contributor

Description of changes

  • Adds getters/setters and helpers to intent checking, replacing all use of a_intent.
  • Rewrites intent selectors to condense/improve code and remove separate intent tracking.
  • Removes direct intent setting on mob definitions in favour of setting via AI init.
  • Changes intent strings to /decl/intent with handling/validation for such.
  • Removes intent_numeric() in favour of using get_next_in_list() and get_previous_in_list() for hotkey cycling.
  • Removes outdated robot intent selector limitations.
  • Adds intent flags preferentially used check checking intent, rather than strict intent types.

Why and what will this PR improve

This is more or less just an infrastructure update to support dynamic intents when I get to them, but it does also clean up some 12 year old crufty code. Tested with humans, robots and nymphs.

Authorship

Myself.

Changelog

Nothing player-facing.

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Nov 28, 2024
@MistakeNot4892
Copy link
Contributor Author

There's a good chance the deity changes break deity, but I am intending to delete it shortly so I am not going to test it.

@MistakeNot4892 MistakeNot4892 added work in progress This PR is under development and shouldn't be merged. and removed ready for review This PR is ready for review and merge. labels Nov 28, 2024
@MistakeNot4892
Copy link
Contributor Author

Need to retest with the diona and psionics changes.

@MistakeNot4892
Copy link
Contributor Author

Commented out nymph intents/intent selectors entirely, they need the full selector for interactions to work and I am unwilling to do more icon work for this PR to fix such a niche side of it. Will revisit with future intent PRs.

@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant