Adding a priority list system for mouse cursor icons. #4587
+110
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
ready for review
|
Fixes/improvements to sideport from my melee branch, DNM. |
MistakeNot4892
force-pushed
the
feature/pointer_priority
branch
3 times, most recently
from
fd8965f
to
679bb77
Compare
MistakeNot4892
added
ready for review
out-of-phaze
previously approved these changes
Dec 2, 2024
| @@ -70,9 +70,6 @@ | |||
| */ | |||
| var/obj/screen/zone_selector/zone_sel = null | |||
|
|
|||
| /// Cursor icon used when holding shift over things. | |||
| var/examine_cursor_icon = 'icons/effects/mouse_pointers/examine_pointer.dmi' | |||
There was a problem hiding this comment.
for parity with the prior system we could specify an examine cursor decl on mob instead
There was a problem hiding this comment.
I don't understand what you mean by parity with the prior system. This var was never changed or used outside of being passed to the pointer.
There was a problem hiding this comment.
mostly that it's a mob var that can be overridden
|
Is there a cursor size? I can try making some. |
|
The existing icon is 32x32 |
MistakeNot4892
force-pushed
the
feature/pointer_priority
branch
from
679bb77
to
7ac5722
Compare
out-of-phaze
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds infrastructure for handling mouse pointer overrides.
Why and what will this PR improve
I need to start adding more cursors for bows and melee weapons so need some infrastructure.
Authorship
Myself.
Changelog
Nothing player-facing.