Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Use system fonts #597

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

moimael
Copy link
Contributor

@moimael moimael commented May 15, 2017

This is the configuration used by Atom and also medium before. It will use the system font on Ubuntu, Gnome, KDE, Windows, MacOS.

Remove the Roboto font except for Terminal which uses the monospace variant.

Maël Lavault added 2 commits May 15, 2017 22:37
Signed-off-by: Maël Lavault <[email protected]>
@lukechampine
Copy link
Member

can you provide screenshots?

Signed-off-by: Maël Lavault <[email protected]>
@moimael
Copy link
Contributor Author

moimael commented May 16, 2017

Here is a screenshot on gnome:
https://pasteboard.co/72qfK22hF.png

@avahowell
Copy link
Contributor

I like this change, but it might be controversial. @DavidVorick @lukechampine thoughts?

@lukechampine
Copy link
Member

hmm. I like having a consistent look across all platforms. What's the main impetus for using system fonts?

@moimael
Copy link
Contributor Author

moimael commented May 16, 2017

It looks more like a system app and less like a website. But as johnatanhowell stated, this is a bit of a controversial topic. I just know that the first time I launched the app, it looked weird to me because of that.
Atom is doing that too, and I wasn't able to check but I guess slack is doing that too. Both apps look very sleek font wise on Linux and feel more like an actual app

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants