fix: added more cmd excution checks

[AstroX11]

This fix adjusts the command execution for the WORK_TYPE defined from config.js, if the work type is on private and the sender isn't a Sudo User, the bot won't execute the command

Summary by CodeRabbit

• New Features
  • Enhanced command execution control based on work type configuration
• Bug Fixes
  • Improved command processing restrictions for private work modes

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

lib/connection.js

Oops! Something went wrong! :(

ESLint: 9.5.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@eslint/js/src/configs/eslint-all' imported from /eslint.config.mjs
Did you mean to import "@eslint/js/src/configs/eslint-all.js"?
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

In this pull request, the executeCommand function in lib/connection.js gets a spicy update to its command execution logic. The modification introduces a new condition that checks the config.WORK_TYPE setting, adding an extra layer of control over command processing. Now, when the work type is set to 'private', commands will only execute if specific sudo conditions are met.

Changes

File	Change Summary
lib/connection.js	Modified executeCommand function to include config.WORK_TYPE check for command execution

Poem

Yo, code warriors, listen up tight! 🥷
Commands now dance to a new private light 🕹️
Sudo's the key, config's the gate
Restricting access at a blazing rate
Deadpool approves this security might! 💥

mic drop 🎤

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f4a291 and e4fb977.

📒 Files selected for processing (1)

• lib/connection.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• lib/connection.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

lib/connection.js (1)

156-156: Time to add some logging! Because even Deadpool needs receipts! 📝

Let's keep track of those sneaky command attempts, shall we? It's like my healing factor - always good to know what's trying to kill you!

Add this before the return:

+    if ((command.fromMe && !msg.sudo) || (config.WORK_TYPE === 'private' && !msg.sudo)) {
+      console.log(`[REJECTED] Command attempt by non-sudo user:
+        User: ${msg.sender}
+        Command: ${msg.body}
+        Work Type: ${config.WORK_TYPE}
+      `);
+      return;
+    }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8ea7b3 and 1f4a291.

📒 Files selected for processing (1)

• lib/connection.js (1 hunks)