Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for AMD compilers #73

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

thilinarmtb
Copy link
Collaborator

No description provided.

@thilinarmtb thilinarmtb marked this pull request as draft February 27, 2024 07:56
@stgeke
Copy link
Contributor

stgeke commented Feb 27, 2024

What was the actual issue?

@yslan
Copy link

yslan commented Feb 27, 2024

This seems to fix the "Floating point exception" error. Tested with kershaw66 case, running on 4 Frontier nodes.

@stgeke
Copy link
Contributor

stgeke commented Feb 27, 2024

Let me ask differently: Can you please explain why the FP-exception happened and how you fixed it.

@thilinarmtb thilinarmtb force-pushed the fixes-for-amd-compilers branch from 4e67918 to 2f66d3a Compare February 27, 2024 18:00
@thilinarmtb thilinarmtb force-pushed the fixes-for-amd-compilers branch from 2f66d3a to 5bbe15b Compare February 27, 2024 18:02
@thilinarmtb
Copy link
Collaborator Author

@stgeke : It was actually a bug on my part that comes up when two level partitioning is on. I guess for GCC, somehow the
floating point exception was not raised.

@thilinarmtb thilinarmtb marked this pull request as ready for review February 28, 2024 15:48
@stgeke stgeke merged commit b8b6f44 into Nek5000:master Feb 28, 2024
27 of 32 checks passed
@thilinarmtb thilinarmtb deleted the fixes-for-amd-compilers branch March 12, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants