Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to turn-off disconnected components calculation #74

Merged

Conversation

thilinarmtb
Copy link
Collaborator

@thilinarmtb thilinarmtb commented Apr 10, 2024

Stop finding the number of disconnected components in the generated partitions.
This takes a very long time when the number of disconnected components are in the
order of 100.

TODO

  • Test the branch on a bigger mesh at scale before merging.

@thilinarmtb thilinarmtb marked this pull request as draft April 10, 2024 10:01
@stgeke
Copy link
Contributor

stgeke commented Apr 10, 2024

Is the warning that there are many disconnected components?

@yslan
Copy link

yslan commented Apr 10, 2024

For our chimera case (E=1.69Bn), it prints something like this and take a very long time

Warning: Lanczos reached a residual of 0.000014 (target: 0.000010) after 50 x 50 iterations in Level=15!
Warning: Partition created 1/1999 (min/max) disconnected components in Level=15!
parrsb_part_mesh_v0: restore original input
parRSB finished in 3261.12 seconds.

@thilinarmtb
Copy link
Collaborator Author

Is the warning that there are many disconnected components?

Yes, it takes a long time if there are a large number of disconnected components.

@stgeke
Copy link
Contributor

stgeke commented Apr 16, 2024 via email

@thilinarmtb
Copy link
Collaborator Author

thilinarmtb commented Apr 16, 2024

What would be a good compromise? Shall we enable finding disconnected components
by default and then have an option to disable it if required?

@stgeke
Copy link
Contributor

stgeke commented Apr 19, 2024

Yeah or we only turn it on for the first N levels.

@thilinarmtb thilinarmtb force-pushed the stop-calculating-disconnected-components branch from ae540bf to 6a9a576 Compare April 23, 2024 17:39
@thilinarmtb
Copy link
Collaborator Author

@stgeke : I added an option to turn-off finding disconnected components if necessary. User can do:

export PARRSB_FIND_NUM_COMPONENTS=0

in order to turn it off. Or this can be set in in the parrsb_options struct when parRSB is called with
the C API.

@thilinarmtb thilinarmtb marked this pull request as ready for review April 23, 2024 17:43
@stgeke
Copy link
Contributor

stgeke commented Apr 23, 2024

I find the name a bit confusing. How about renaming it to PARRSB_FIND_DISCONNECTED_COMPONENTS ?

@thilinarmtb thilinarmtb changed the title Stop calculating disconnected components Add an option to turn-off disconnected components calculation Apr 23, 2024
@thilinarmtb thilinarmtb force-pushed the stop-calculating-disconnected-components branch from 031acc8 to 2505e33 Compare April 23, 2024 19:36
@thilinarmtb thilinarmtb force-pushed the stop-calculating-disconnected-components branch from 2505e33 to 979b125 Compare April 25, 2024 07:14
@stgeke stgeke merged commit fdd4d07 into Nek5000:master Apr 29, 2024
27 of 32 checks passed
@thilinarmtb thilinarmtb deleted the stop-calculating-disconnected-components branch April 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants