Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nis]: add additional block info to /local/block/at #538

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

Jaguar0625
Copy link
Contributor

problem: cannot determine block beneficiary directly
solution: add 'beneficiary' and 'totalFee' to result from /local/block/at

@Jaguar0625 Jaguar0625 requested a review from Wayonb August 12, 2024 22:35
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (67de650) to head (b60b352).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #538   +/-   ##
=========================================
  Coverage     93.51%   93.51%           
- Complexity     5981     5982    +1     
=========================================
  Files           709      709           
  Lines         17086    17088    +2     
  Branches       1278     1279    +1     
=========================================
+ Hits          15978    15980    +2     
  Misses          862      862           
  Partials        246      246           
Flag Coverage Δ
gocrypto 77.04% <ø> (ø)
nem-core 95.51% <ø> (ø)
nem-deploy 52.98% <ø> (ø)
nem-nis 94.11% <100.00%> (+<0.01%) ⬆️
nem-peer 94.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../controller/viewmodels/ExplorerBlockViewModel.java 100.00% <100.00%> (ø)

Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

 problem: cannot determine block beneficiary directly
solution: add 'beneficiary' and 'totalFee' to result from /local/block/at
@Jaguar0625 Jaguar0625 merged commit b60b352 into dev Aug 13, 2024
12 checks passed
@Jaguar0625 Jaguar0625 deleted the rosetta-changes branch August 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants