-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use type traits in linear solving #1738
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1738 +/- ##
==========================================
+ Coverage 87.39% 87.70% +0.30%
==========================================
Files 117 117
Lines 29919 30160 +241
==========================================
+ Hits 26149 26451 +302
+ Misses 3770 3709 -61 ☔ View full report in Codecov by Sentry. |
* possibly transpose less * make it usable for Nemo
I don't fully understand what's going on there. An Aqua test in Nemo is failing and I have the impression that it is testing Nemo against the released version of AbstractAlgebra. Then this
would be expected. |
This is probably due to JuliaTesting/Aqua.jl#292 |
So far this does not change the functionality. I open this pull request already now to discuss names and the design.
I will add the new Howell form to the system and try to clean up more of the
_can_solve...
methods insrc/Matrix.jl
(no promises on this though).Oh, and this will break Nemo in the current state.