Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type traits in linear solving #1738

Merged
merged 21 commits into from
Jul 18, 2024
Merged

Use type traits in linear solving #1738

merged 21 commits into from
Jul 18, 2024

Conversation

joschmitt
Copy link
Collaborator

@joschmitt joschmitt commented Jul 2, 2024

So far this does not change the functionality. I open this pull request already now to discuss names and the design.

I will add the new Howell form to the system and try to clean up more of the _can_solve... methods in src/Matrix.jl (no promises on this though).

Oh, and this will break Nemo in the current state.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 98.45201% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.70%. Comparing base (abdcb76) to head (ec35a1e).
Report is 4 commits behind head on master.

Files Patch % Lines
src/Solve.jl 98.45% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1738      +/-   ##
==========================================
+ Coverage   87.39%   87.70%   +0.30%     
==========================================
  Files         117      117              
  Lines       29919    30160     +241     
==========================================
+ Hits        26149    26451     +302     
+ Misses       3770     3709      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Solve.jl Outdated Show resolved Hide resolved
src/Solve.jl Outdated Show resolved Hide resolved
@thofma
Copy link
Member

thofma commented Jul 17, 2024

@joschmitt
Copy link
Collaborator Author

https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/9975920868/job/27580200035?pr=1738 should be working?

I don't fully understand what's going on there. An Aqua test in Nemo is failing and I have the impression that it is testing Nemo against the released version of AbstractAlgebra. Then this

WARNING: could not import AbstractAlgebra.howell_form! into Nemo
ERROR: LoadError: UndefVarError: `matrix_normal_form_type` not defined

would be expected.

@lgoettgens
Copy link
Collaborator

Nemocas/AbstractAlgebra.jl/actions/runs/9975920868/job/27580200035?pr=1738 should be working?

I don't fully understand what's going on there. An Aqua test in Nemo is failing and I have the impression that it is testing Nemo against the released version of AbstractAlgebra. Then this

WARNING: could not import AbstractAlgebra.howell_form! into Nemo
ERROR: LoadError: UndefVarError: `matrix_normal_form_type` not defined

would be expected.

This is probably due to JuliaTesting/Aqua.jl#292

@lgoettgens lgoettgens closed this Jul 18, 2024
@lgoettgens lgoettgens reopened this Jul 18, 2024
@lgoettgens lgoettgens requested a review from thofma July 18, 2024 15:01
@thofma thofma merged commit 0ecb069 into Nemocas:master Jul 18, 2024
52 of 60 checks passed
@joschmitt joschmitt deleted the js/traits branch July 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants