-
Notifications
You must be signed in to change notification settings - Fork 0
Add hw4_test_coverage solution #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
OrderBy int | ||
} | ||
|
||
type SearchClient struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type SearchClient should have comment or be unexported
ErrorBadOrderField = `OrderField invalid` | ||
) | ||
|
||
type SearchRequest struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type SearchRequest should have comment or be unexported
} | ||
|
||
const ( | ||
OrderByAsc = -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported const OrderByAsc should have comment (or a comment on this block) or be unexported
NextPage bool | ||
} | ||
|
||
type SearchErrorResponse struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type SearchErrorResponse should have comment or be unexported
Gender string | ||
} | ||
|
||
type SearchResponse struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type SearchResponse should have comment or be unexported
) | ||
|
||
type User struct { | ||
Id int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
struct field Id should be ID
client = &http.Client{Timeout: time.Second} | ||
) | ||
|
||
type User struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type User should have comment or be unexported
No description provided.