Skip to content

Add hw4_test_coverage solution #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Neodelf
Copy link
Owner

@Neodelf Neodelf commented Feb 10, 2019

No description provided.

OrderBy int
}

type SearchClient struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchClient should have comment or be unexported

ErrorBadOrderField = `OrderField invalid`
)

type SearchRequest struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchRequest should have comment or be unexported

}

const (
OrderByAsc = -1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported const OrderByAsc should have comment (or a comment on this block) or be unexported

NextPage bool
}

type SearchErrorResponse struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchErrorResponse should have comment or be unexported

Gender string
}

type SearchResponse struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchResponse should have comment or be unexported

)

type User struct {
Id int
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

struct field Id should be ID

client = &http.Client{Timeout: time.Second}
)

type User struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type User should have comment or be unexported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant