Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: neon iris websat for helm #58

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mikejgray
Copy link

Description

Adds Helm chart for the iris-websat image.

Issues

N/A

Other Notes

I'm not sure if this is everything that's needed, and there definitely needs to be an update to neon.yaml to properly set the websocket URL for it to work. I couldn't find where to do that though.

Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NeonGeckoCom/neon-diana-utils/blob/dev/neon_diana_utils/templates/neon/Chart.yaml should also be updated here to include this deployment by default.

We should also consider a single ingress spec for both (more in the future?) web services that go with neon-core

@NeonDaniel
Copy link
Member

We should also consider a single ingress spec for both (more in the future?) web services that go with neon-core

#59 will include some refactoring for this. Ingress will support more services that can be enabled/disabled as part of the diana configure-neon CLI command


dependencies:
- name: base-neon
version: 0.0.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 0.0.5 now

@@ -0,0 +1,38 @@
{{ if .Values.ingress.enabled }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use the base-neon.ingress template?

{{- include "base-neon.ingress" . }}

@@ -0,0 +1,27 @@
serviceName: neon-core-iris-websat
subdomain: iris
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is referenced anywhere looking at the neon-iris chart for comparison

tlsSecretName: tls-letsencrypt-iris-websat
certIssuer: letsencrypt-private-key
rules:
- host: iris
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neon-iris uses this default host, can this be websat or satellite (or similar) instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants