Reconstruct msmps from disk and archive #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to allow the user to reconstruct the mutator set membership proofs in case the wallet database is corrupted or lost. The reconstruction of MS membership proofs have not yet been programmed. Cf. #23.
It might not be a good idea to store any path in `WalletSecret`. It could create some serious porting issues, as all values are JSON encoded. Can we avoid storing this path there?
Also moves the functions to recover MUTXOs from wallet secret to wallet state. The problem with storing a directory in a wallet secret file is that it would make porting the wallet to another directory (e.g. across operating systems) error-prone.
This function was leaking test-handling which could and ought to be contained to the `tests/shared.rs` module. This commit achieves that. Also changes the name of the wallet db to be in line with the other database names.
Sword-Smith
force-pushed
the
reconstruct-msmps-from-disk-and-archive
branch
from
efbd991
to
51469a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.