Ports Hybrissa to Neroids/Xenosurge PvE codebase #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silencer-pl
changed the title
|
Yay, ready for testmerging etc. What a lovely way to spend a Monday :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a functional port of Hybrisa Prospera - cmss13-devs/cmss13#6248 from the main CM codebase onto PvE, to be used as part of the Xenosurge events on my end, but obviously for anyone to use at will.
The port takes a few shortcuts and also grabs a few "dummy" items to act as placeholders for stuff from the main CM branch that PvE didn't or couldn't port. Don't know what their intent on codebase parity are, but if one catches up to the other, this will become moot.
Anyway, this skips a few of CMs cosmetic items that aren't in the PvE code but creates props for most strctures etc. Only things that didn't get ported is stuff like the black zippos on the maps itself. Again, this only will become an issue should PvE's upstream ever do this themselves, likely less sloppily than me :P
This still needs a final test to see if any map mechanics broke and I'm sure the linter/repo test will blow up somehow.
EDIT: I should be close to resolving all linter etc errors which included a whole lot of icons because I was lazy. Anyway, a test should still be likely done to make sure map mechanics are intact and obviously this still needs to be added to the actual rotation.