fix(DataProtectionStore): change alg creation strategy

BREAKING CHANGE: Changed DataProtection protector

src/NetDevPack.Security.Jwt/DefaultStore/DataProtectionStore.cs

@@ -37,8 +37,7 @@ public class DataProtectionStore : IJsonWebKeyStore
         private readonly IOptions<KeyManagementOptions> _keyManagementOptions;
         private readonly IMemoryCache _memoryCache;
         private readonly IDataProtector _dataProtector;
-
-        private IXmlRepository KeyRepository { get; set; }
+        private IXmlRepository KeyRepository => _keyManagementOptions.Value.XmlRepository ?? GetFallbackKeyRepositoryEncryptorPair();
 
         private const string Name = "NetDevPackSecurityJwt";
 
@@ -53,9 +52,7 @@ public DataProtectionStore(
             _options = options;
             _keyManagementOptions = keyManagementOptions;
             _memoryCache = memoryCache;
-            _dataProtector = provider.CreateProtector(typeof(SecurityKeyWithPrivate).AssemblyQualifiedName); ;
-            Check();
-            // Force it to configure xml repository.
+            _dataProtector = provider.CreateProtector(nameof(SecurityKeyWithPrivate)); ;
         }
         public void Save(SecurityKeyWithPrivate securityParamteres)
         {
@@ -78,15 +75,6 @@ public void Save(SecurityKeyWithPrivate securityParamteres)
             ClearCache();
         }
 
-        private void Check()
-        {
-            KeyRepository = _keyManagementOptions.Value.XmlRepository;
-            if (KeyRepository == null)
-            {
-                KeyRepository = GetFallbackKeyRepositoryEncryptorPair();
-            }
-        }
-
 
 
         public SecurityKeyWithPrivate GetCurrentKey(JsonWebKeyType jwkType)

src/NetDevPack.Security.Jwt/Interfaces/IJsonWebKeyService.cs

@@ -4,6 +4,6 @@ namespace NetDevPack.Security.Jwt.Interfaces
 {
     public interface IJsonWebKeyService
     {
-        JsonWebKey Generate(Algorithm jwsAlgorithm);
+        JsonWebKey Generate(Algorithm algorithm);
     }
 }

src/NetDevPack.Security.Jwt/JsonWebKeySetManagerDependencyInjection.cs

@@ -1,10 +1,10 @@
-using System;
-using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.DependencyInjection;
 using NetDevPack.Security.Jwt.DefaultStore;
 using NetDevPack.Security.Jwt.DefaultStore.Memory;
 using NetDevPack.Security.Jwt.Interfaces;
 using NetDevPack.Security.Jwt.Jwk;
 using NetDevPack.Security.Jwt.Jwks;
+using System;
 
 namespace NetDevPack.Security.Jwt
 {

src/NetDevPack.Security.Jwt/Jwk/JwkService.cs

@@ -14,19 +14,8 @@ private JsonWebKey GenerateRsa()
         private JsonWebKey GenerateECDsa(Algorithm algorithm)
         {
             var key = CryptoService.CreateECDsaSecurityKey(algorithm);
-            var parameters = key.ECDsa.ExportParameters(true);
-            return new JsonWebKey()
-            {
-                Kty = JsonWebAlgorithmsKeyTypes.EllipticCurve,
-                Use = "sig",
-                Kid = key.KeyId,
-                KeyId = key.KeyId,
-                X = Base64UrlEncoder.Encode(parameters.Q.X),
-                Y = Base64UrlEncoder.Encode(parameters.Q.Y),
-                D = Base64UrlEncoder.Encode(parameters.D),
-                Crv = CryptoService.GetCurveType(algorithm),
-                Alg = algorithm
-            };
+            return JsonWebKeyConverter.ConvertFromECDsaSecurityKey(key);
+
         }
         private JsonWebKey GenerateHMAC(Algorithm jwsAlgorithms)
         {
@@ -45,15 +34,15 @@ private JsonWebKey GenerateAES(Algorithm jwsAlgorithms)
             return jwk;
         }
 
-        public JsonWebKey Generate(Algorithm jwsAlgorithm)
+        public JsonWebKey Generate(Algorithm algorithm)
         {
-            return jwsAlgorithm.KeyType switch
+            return algorithm.KeyType switch
             {
                 KeyType.RSA => GenerateRsa(),
-                KeyType.ECDsa => GenerateECDsa(jwsAlgorithm),
-                KeyType.HMAC => GenerateHMAC(jwsAlgorithm),
-                KeyType.AES => GenerateAES(jwsAlgorithm),
-                _ => throw new ArgumentOutOfRangeException(nameof(jwsAlgorithm), jwsAlgorithm, null)
+                KeyType.ECDsa => GenerateECDsa(algorithm),
+                KeyType.HMAC => GenerateHMAC(algorithm),
+                KeyType.AES => GenerateAES(algorithm),
+                _ => throw new ArgumentOutOfRangeException(nameof(algorithm), algorithm, null)
             };
         }
 

src/NetDevPack.Security.Jwt/NetDevPack.Security.Jwt.csproj

@@ -18,6 +18,7 @@
   <ItemGroup>
     <PackageReference Include="System.Text.Json" Version="5.0.2" />
     <PackageReference Include="Microsoft.IdentityModel.Tokens" Version="6.12.2" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="5.0.2" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.1'">
     <PackageReference Include="Microsoft.Extensions.Options" Version="3.1.15" />

tests/NetDevPack.Security.Jwt.IdentityServer4.Tests/Startup.cs

@@ -36,6 +36,7 @@ public void ConfigureServices(IServiceCollection services)
                 .AddInMemoryApiResources(Config.GetApis())
                 .AddInMemoryClients(Config.GetClients());
 
+
             services.AddJwksManager().IdentityServer4AutoJwksManager();
         }