Update to Snakeyaml 2.2 #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
force-pushed
the
feature/snakeyaml-2
branch
from
5eb9e31 to
6897604
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kwin
commented
Mar 14, 2023
| @@ -23,7 +24,7 @@ | |||
| * Usually this is called with | |||
| * <a href="https://github.com/apache/felix-dev/tree/master/configadmin-plugins/interpolation">Felix Configadmin Interpolation Plugin</a>. | |||
| * | |||
| * @see <a href="https://bitbucket.org/asomov/snakeyaml/wiki/Variable%20substitution">Variable substitution</a> | |||
| * @see <a href="https://bitbucket.org/snakeyaml/snakeyaml/wiki/Variable%20substitution">Variable substitution</a> | |||
There was a problem hiding this comment.
should extend SafeConstructor
There was a problem hiding this comment.
If I read https://snyk.io/blog/snakeyaml-unsafe-deserialization-vulnerability/ correctly, we should really be safe by just using snakeyaml-2.0 because by default the class deserialization is not active anymore and we are not using this features anywhere.
kwin
force-pushed
the
feature/snakeyaml-2
branch
from
dcc0d86 to
6897604
Compare
kwin
force-pushed
the
feature/snakeyaml-2
branch
from
73ae011 to
c9193de
Compare
ghenzler
force-pushed
the
feature/snakeyaml-2
branch
from
8e5249c to
6a43113
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ghenzler
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #660