Also interpret cost JSON object in case it is returned by oak search engine #731
Conversation
|
|
||
| // use jackson for JSON parsing | ||
| ObjectMapper mapper = new ObjectMapper(); | ||
| String costJsonStr = plan.substring(plan.lastIndexOf('{')); |
There was a problem hiding this comment.
Probably we should log the JSON (on debug/verbose level) in case it changes in the future, so that we can more easily come up with a fix.
| // read the json strings and convert it into JsonNode | ||
| JsonNode node = mapper.readTree(jsonStr); | ||
|
|
||
| JsonNode sNode = node.get("s"); |
There was a problem hiding this comment.
We need some more null checks here and a unit test with invalid JSON.
| JsonNode node = mapper.readTree(jsonStr); | ||
|
|
||
| JsonNode sNode = node.get("s"); | ||
| double cost = sNode.isContainerNode() ? sNode.get("perExecution").asDouble(Double.MAX_VALUE) : sNode.asDouble(Double.MAX_VALUE); |
There was a problem hiding this comment.
let us null check sNode.get("perExecution") as well.
Include index usage in AC Tool log Fix JSON retrieval from plan
ghenzler
force-pushed
the
bugfix/730-also-interpret-cost-json-object-correctly
branch
from
9f855a5 to
8456ecf
Compare
| } catch(IOException|RepositoryException e) { | ||
| LOG.warn("Cannot figure out if query index for rep:ACL nodes exist", e); | ||
| } catch(Exception e) { | ||
| LOG.warn("Could not detect if query index for rep:ACL nodes exists: {}", e.getMessage(), e); | ||
| } |
There was a problem hiding this comment.
no matter what exception is thrown this warning should be shown
| // use jackson for JSON parsing | ||
| ObjectMapper mapper = new ObjectMapper(); | ||
| LOG.debug("Execution plan and cost for {}: {}", EXPLAIN_QUERY_FOR_ACL_INDEX, plan); | ||
| String costJsonStr = StringUtils.substringAfter(plan, "cost:"); |
There was a problem hiding this comment.
just checking for { is also very unsafe - conceptually better to check for the string after cost:. (plan.substring(plan.lastIndexOf('{')) returned only parts of the cost json)
|
Closes #730