Add field impersonationAllowedFor to autoCreateTestUsers #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Please also adjust the documentation in https://github.com/Netcentric/accesscontroltool/blob/develop/docs/AdvancedFeatures.md#auto-create-test-users-for-groups
pom.xml
Outdated
| @@ -426,7 +426,7 @@ | |||
| <plugin> | |||
| <groupId>org.owasp</groupId> | |||
| <artifactId>dependency-check-maven</artifactId> | |||
| <version>9.0.10</version> | |||
| <version>10.0.1</version> | |||
There was a problem hiding this comment.
Please remove those changes, they are incorporated in develop now.
kwin
requested changes
Jul 11, 2024
docs/AdvancedFeatures.md
Outdated
| @@ -292,6 +292,7 @@ property | comment | required | |||
| `path` | The location where the test users shall be created | required | |||
| `password` | The password for all test users to be created. Can be encrypted using CryptoSupport. Defaults simply to the authorizable id of the test user. Allows for interpolation with EL *) | optional | |||
| `skipForRunmodes` | The configuration is placed in a regular config file, hence it is possible to add one to an author configuration (located in e.g. in a folder "config.author" and one to a publish configuration (e.g. folder "config.publish"). To avoid creating special runmodes folders just for this configuration that list all runmodes except production, skipForRunmodes can be a comma-separated list of runmodes, where the users are not created. Defaults to prod,production | optional | |||
| `impersonationAllowedFor` | List of users that can be impersonated by auto-created test users | optional | |||
There was a problem hiding this comment.
It is the other way around, those users are allowed to impersonate the auto-created test users!
|
kwin
deleted the
feature/723_add-field-impersonators-to-autoCreateTestUsers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.