Create MSK Serverless scrape config #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brituck
commented
Dec 10, 2024
brituck
commented
Dec 10, 2024
manolama
requested changes
Dec 10, 2024
There was a problem hiding this comment.
And add the file to https://github.com/Netflix-Skunkworks/iep-apps/blob/main/atlas-cloudwatch/src/main/resources/reference.conf#L630 please.
| dimensions = [ | ||
| "Cluster Name", | ||
| "Topic", | ||
| "Consumer Group" |
There was a problem hiding this comment.
We'll need to keep an eye on cardinality here if there will be multiple groups for a large # of topics.
There was a problem hiding this comment.
Also, add these three to the tag map in https://github.com/Netflix-Skunkworks/iep-apps/blob/main/atlas-cloudwatch/src/main/resources/reference.conf#L236 with dotted notation for Atlas please.
| ] | ||
| } | ||
|
|
||
| msk-serverless-consumergroup = { |
There was a problem hiding this comment.
| cloudwatch { | ||
|
|
||
| // https://docs.aws.amazon.com/msk/latest/developerguide/serverless-monitoring.html | ||
| msk-serverless-cluster = { |
There was a problem hiding this comment.
manolama
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InfraAPI is using AWS MSK Serverless for event streaming. Adds MSK serverless metrics config for atlas. See https://docs.aws.amazon.com/msk/latest/developerguide/serverless-monitoring.html for metrics details.