Skip to content

Commit

Permalink
tests: Remove "is proto fresh" test in lieu of GitHub Action (apollog…
Browse files Browse the repository at this point in the history
…raphql#5031)

We'll have a GitHub Action do the maintenance on this file, rather than
having a test remind us that it's stale. The test results in all PRs
(and
all downstream users of this repository) suddenly getting failing tests
every time our infra-team deploys a new version of the proto, whereas
the
GitHub Action can be a much more controlled burn.

The GitHub action that replaces this is in [apollographql#5030], and we will merge
this test just as soon as that is validated.

[apollographql#5030]: apollographql#5030
  • Loading branch information
abernix authored Apr 26, 2024
1 parent f8ad977 commit 0137e0c
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions apollo-router/src/plugins/telemetry/apollo_exporter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -442,17 +442,3 @@ where
None => serializer.serialize_none(),
}
}

#[cfg(not(windows))] // git checkout converts \n to \r\n, making == below fail
#[test]
fn check_reports_proto_is_up_to_date() {
let proto_url = "https://usage-reporting.api.apollographql.com/proto/reports.proto";
let response = reqwest::blocking::get(proto_url).unwrap();
let content = response.text().unwrap();
// Not using assert_eq! as printing the entire file would be too verbose
assert!(
content == include_str!("proto/reports.proto"),
"Protobuf file is out of date. Run this command to update it:\n\n \
curl -f {proto_url} > apollo-router/src/plugins/telemetry/proto/reports.proto\n\n"
);
}

0 comments on commit 0137e0c

Please sign in to comment.