reduce spectatord logging #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Sent:` messages serve as a positive confirmation that spectatord is either delivering or dropping measurements, but there is generally no action to be taken from it directly, and this information is also recorded in the `spectator.measurements` metric. In the case of Titus, this message alone is responsible for 25% of all logs. Moving this message to the `debug` level drops it from the standard use case, while still allowing it to be accessed if the `--verbose` flag is passed to the binary. Fixes Netflix-Skunkworks#71.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Sent:messages serve as a positive confirmation that spectatord is either delivering or dropping measurements, but there is generally no action to be taken from it directly, and this information is also recorded in thespectator.measurementsmetric.In the case of Titus, this message alone is responsible for 25% of all logs.
Moving this message to the
debuglevel drops it from the standard use case, while still allowing it to be accessed if the--verboseflag is passed to the binary.Fixes #71.