add --no_common_tags flag #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copperlight
force-pushed
the
no-common-tags
branch
5 times, most recently
from
2bf2ffb to
6839a74
Compare
The purpose of this flag is to remove all common tags, so that users can override any common tags they wish, including `nf.app`, by providing them in the protocol line. Note that a proper environment is still required, so that the publish URI can be determined correctly. This feature should only be used for secondary spectatord processes on an instance. A standard process should exist, so that atlas-system-agent metrics can be received and published. When this feature is active, the publishing of internal status metrics is disabled, because we cannot attribute the metrics correctly in the absence of common tags.
copperlight
force-pushed
the
no-common-tags
branch
from
6839a74 to
1e5cddc
Compare
copperlight
added a commit
to copperlight/spectatord
that referenced
this pull request
Jun 17, 2024
This change is related to the work in the previous PR: Netflix-Skunkworks#89
copperlight
added a commit
that referenced
this pull request
Jun 17, 2024
) This change is related to the work in the previous PR: #89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this flag is to remove all common tags, so that users can override any common tags they wish, including
nf.app, by providing them in the protocol line. Note that a proper environment is still required, so that the publish URI can be determined correctly.This feature should only be used for secondary spectatord processes on an instance. A standard process should exist, so that atlas-system-agent metrics can be received and published.
When this feature is active, the publishing of internal status metrics is disabled, because we cannot attribute the metrics correctly in the absence of common tags.