Skip to content

Commit

Permalink
eval: use consistent setting for simple legends (#1620)
Browse files Browse the repository at this point in the history
Since eval output will now use graph settings to enable
presentation metadata, use the same setting for simple
legends to avoid confusion.
  • Loading branch information
brharrington authored Mar 5, 2024
1 parent 86a7157 commit f883a6a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
5 changes: 0 additions & 5 deletions atlas-eval/src/main/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ atlas.eval {

// Which version of the LWC server API to use
lwcapi-version = 2

// If set to true, then it will try to generate a simple legend for the set of expressions
// on the graph. By default the legend will just summarize the expression which is often
// long and hard to read for users.
simple-legends-enabled = true
}

graph {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ private[stream] class ExprInterpreter(config: Config) {

// Use simple legends for expressions
private val simpleLegendsEnabled: Boolean =
config.getBoolean("atlas.eval.stream.simple-legends-enabled")
config.getBoolean("atlas.eval.graph.simple-legends-enabled")

def eval(expr: String): List[StyleExpr] = {
val exprs = interpreter.execute(expr).stack.map {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ object TestContext {
| expression-limit = 50000
|
| ignored-tag-keys = []
|
| simple-legends-enabled = false
|}
|
|atlas.eval.graph {
Expand Down

0 comments on commit f883a6a

Please sign in to comment.