Ensure the inflight metrics are properly updated when rejecting #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the inflight metrics only update when a successful listener is acquired. However, in cases where all inflight requests are tied up and everything is being rejected, the inflight counter never updates. This causes the metric to eventually fall off and "appear" as 0 inflight. This change always publishes the inflight distribution to ensure it is always published with its current value.
fedorka
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the inflight metrics only update when a successful listener is acquired. However, in cases where all inflight requests are tied up and everything is being rejected, the inflight counter never updates. This causes the metric to eventually fall off and "appear" as 0 inflight. This change always publishes the inflight distribution to ensure it is always published with its current value.