Reduce contention a little in AbstractPartitionedLimiter #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enbnt
reviewed
Aug 26, 2024
...ts-core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiter.java
Outdated
Show resolved
Hide resolved
enbnt
reviewed
Aug 26, 2024
...ts-core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiter.java
Outdated
Show resolved
Hide resolved
enbnt
reviewed
Aug 26, 2024
...ts-core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiter.java
Outdated
Show resolved
Hide resolved
guarantees ordering visibility
added a comment to the predicate setup to discourage accessing limiter while inside predicate
jasonk000
commented
Aug 27, 2024
...ts-core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiter.java
Outdated
Show resolved
Hide resolved
enbnt
reviewed
Aug 28, 2024
...ts-core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiter.java
Outdated
Show resolved
Hide resolved
enbnt
reviewed
Aug 30, 2024
...ore/src/test/java/com/netflix/concurrency/limits/limiter/AbstractPartitionedLimiterTest.java
Outdated
Show resolved
Hide resolved
enbnt
reviewed
Aug 30, 2024
...ency-limits-core/src/test/java/com/netflix/concurrency/limits/limiter/SimpleLimiterTest.java
Outdated
Show resolved
Hide resolved
fedorka
approved these changes
Aug 30, 2024
enbnt
approved these changes
Aug 30, 2024
umairk79
approved these changes
Sep 3, 2024
github-merge-queue bot
referenced
this pull request
in camunda/camunda
Sep 4, 2024
…mits-core to v0.5.2 (main) (#21898) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.netflix.concurrency-limits:concurrency-limits-core](https://redirect.github.com/Netflix/concurrency-limits) | `0.5.1` -> `0.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Netflix/concurrency-limits (com.netflix.concurrency-limits:concurrency-limits-core)</summary> ### [`v0.5.2`](https://redirect.github.com/Netflix/concurrency-limits/releases/tag/v0.5.2) [Compare Source](https://redirect.github.com/Netflix/concurrency-limits/compare/v0.5.1...v0.5.2) ##### What's Changed - Remove unused imports and replace deprecated JUnit import by [@​arouel](https://redirect.github.com/arouel) in [https://github.com/Netflix/concurrency-limits/pull/203](https://redirect.github.com/Netflix/concurrency-limits/pull/203) - Prevent duplicate publishing on release by [@​umairk79](https://redirect.github.com/umairk79) in [https://github.com/Netflix/concurrency-limits/pull/201](https://redirect.github.com/Netflix/concurrency-limits/pull/201) - Reduce contention a little in AbstractPartitionedLimiter by [@​jasonk000](https://redirect.github.com/jasonk000) in [https://github.com/Netflix/concurrency-limits/pull/204](https://redirect.github.com/Netflix/concurrency-limits/pull/204) ##### New Contributors - [@​arouel](https://redirect.github.com/arouel) made their first contribution in [https://github.com/Netflix/concurrency-limits/pull/203](https://redirect.github.com/Netflix/concurrency-limits/pull/203) - [@​jasonk000](https://redirect.github.com/jasonk000) made their first contribution in [https://github.com/Netflix/concurrency-limits/pull/204](https://redirect.github.com/Netflix/concurrency-limits/pull/204) **Full Changelog**: Netflix/concurrency-limits@v0.5.1...v0.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/camunda/camunda). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap
busyfrom aninttoAtomicInteger, which eliminates need for areleaseto take the lock.And while we are here, slim down the work done while holding the lock.