Use IntUnaryOperator / DoubleUnaryOperator in VegasLimit #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilink
commented
Sep 19, 2024
...its-core/src/main/java/com/netflix/concurrency/limits/limit/functions/Log10RootFunction.java
Outdated
Show resolved
Hide resolved
kilink
force-pushed
the
vegas-limit-int-unary-operator
branch
from
20db64c
to
711f387
Compare
enbnt
reviewed
Oct 4, 2024
concurrency-limits-core/src/test/java/com/netflix/concurrency/limits/limit/VegasLimitTest.java
Show resolved
Hide resolved
kilink
force-pushed
the
vegas-limit-int-unary-operator
branch
2 times, most recently
from
b5ddc17
to
3fbad85
Compare
enbnt
reviewed
Oct 23, 2024
|
|
||
| probeCount++; | ||
| if (shouldProbe()) { | ||
| LOG.debug("Probe MinRTT {}", TimeUnit.NANOSECONDS.toMicros(rtt) / 1000.0); | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("Probe MinRTT {}", TimeUnit.NANOSECONDS.toMicros(rtt) / 1000.0); |
enbnt
reviewed
Oct 23, 2024
| rtt_noload = rtt; | ||
| return (int)estimatedLimit; | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("New MinRTT {}", TimeUnit.NANOSECONDS.toMicros(rtt) / 1000.0); |
enbnt
reviewed
Oct 23, 2024
...-core/src/main/java/com/netflix/concurrency/limits/limit/functions/Log10RootIntFunction.java
Show resolved
Hide resolved
Switch to IntUnaryOperator and DoubleUnaryOperator in VegasLimit to avoid unnecessary boxing. Additionally, reduced repeated reads of volatile fields.
kilink
force-pushed
the
vegas-limit-int-unary-operator
branch
from
3fbad85
to
a127eb4
Compare
enbnt
approved these changes
Oct 25, 2024
umairk79
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to IntUnaryOperator and DoubleUnaryOperator in VegasLimit to avoid unnecessary boxing. Additionally, reduced repeated reads of volatile fields.